AndrewBennet / ReadingListV1

:books: :iphone: Reading List - an iOS app to track personal reading lists
https://readinglist.app
GNU General Public License v3.0
300 stars 48 forks source link

Show the count of items instead of "All" when multi-selecting items #48

Closed bryanjclark closed 3 years ago

bryanjclark commented 4 years ago

The other day, I was cleaning up my list of To-Read books, and used the Edit > Multiselect > Delete option (this is editActionButtonPressed in the source code).

The UIAlertController's actions had titles that caught me off guard - for a moment, I thought that tapping the Delete (or Start) buttons would delete all the books in my To-Read list (of course, the actual feature is to delete only the selected ones!)

I think there are a bunch of ways to consider for changing the copy - the two that come to mind for me are "Delete 2", or "Delete Selected".

What do you prefer? I think I prefer the count, but could go either way.

Napkin 2 08-24-20, 9 16 11 AM
AndrewBennet commented 3 years ago

Hey sorry I didn't pick this pull request up sooner. I was mulling the wording over for a while -- I agree that "All" wasn't the best word use, but I wondered whether "Start 3" might also be confusing the first time someone sees it. In the end, I settled on "Start Selected" as a balance. It's more explicit about what items you're taking action on, even if you don't have the number in the action itself (but the number is in the navigation title though).

As part of the iOS 14 updates, I switched this action sheet to a menu item, and I made this wording change in place, so this in fact already went out in the recent iOS 14 support update. I'll close this pull request; thanks for starting it!

489A73D2-C258-4B5A-B964-8E02271E6889_1_201_a