search

AndrewCRMartin / JSAV

JavaScript Sequence Alignment Viewer
GNU General Public License v2.0
11 stars 5 forks source link

Use dom manipulation to add JSAV to a webpage #1

Closed jenshnielsen closed 9 years ago

jenshnielsen commented 9 years ago

Currently this will add the JSAV element to the div specified by id if it can be found otherwise a new div is created and inserted at the end of the page. I could not find a good way of inserting in the DOM at the position of the script tag. There were some suggestions on Stackoverflow but they were not reliable.

AndrewCRMartin commented 9 years ago

Hi Jens,

I've merged in your changes and added a few more documentation of changes comments in my standard style. This is now released as V1.6

A.

On Wed, Sep 17, 2014 at 1:12 PM, Jens Hedegaard Nielsen < notifications@github.com> wrote:

You can merge this Pull Request by running

git pull https://github.com/jenshnielsen/JSAV master

Or view, comment on, or merge it at:

https://github.com/AndrewCRMartin/JSAV/pull/1 Commit Summary

  • Add bower file
  • Add tooltipster
  • Ensure that AA in colour class is always uppercase. XHTML is case sensitive (abYsis is xhtml)
  • Use dom manipulation rather than write and writeln to insert HTML, Fixes overwrite when used after page load (In Ajax)
  • tag 1.5.3
  • This should not be commented out

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/AndrewCRMartin/JSAV/pull/1.

Dr. Andrew C.R. Martin, Reader in Bioinformatics and Computational Biology. Institute of Structural and Molecular Biology, UCL http://www.bioinf.org.uk/ Twitter: @DrAndrewMartin