AndrewDongminYoo / react-native-step-counter

[๋ฆฌ์•กํŠธ ๋„ค์ดํ‹ฐ๋ธŒ ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ] ์‚ฌ์šฉ์ž์˜ ๊ฑธ์Œ ์ˆ˜๋ฅผ ๊ณ„์‚ฐํ•ฉ๋‹ˆ๋‹ค. Android๋Š” StepCounter (or Accelerometer) ์„ผ์„œ API๋ฅผ, iOS๋Š” CoreMotion CMPedometer ๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ ๊ฑธ์Œ ์ˆ˜๋ฅผ ์ธก์ •ํ•ฉ๋‹ˆ๋‹ค.
https://andrewdongminyoo.github.io/react-native-step-counter/
MIT License
29 stars 10 forks source link

Command "rnx-align-deps" not found. #30

Closed aluxmanu closed 1 year ago

aluxmanu commented 1 year ago

Hi @AndrewDongminYoo I was trying to test your changes from the other bug but when I run yarn add @dongminyu/react-native-step-counter I get this error:

yarn add @dongminyu/react-native-step-counter
yarn add v1.22.19
[1/4] ๐Ÿ”  Resolving packages...
[2/4] ๐Ÿšš  Fetching packages...
[3/4] ๐Ÿ”—  Linking dependencies...
[4/4] ๐Ÿ”จ  Building fresh packages...
error /Users/app-name/node_modules/@dongminyu/react-native-step-counter: Command failed.
Exit code: 1
Command: yarn rnx-align-deps --write
Arguments: 
Directory: /Users/app-name/node_modules/@dongminyu/react-native-step-counter
Output:
yarn run v1.22.19
error Command "rnx-align-deps" not found.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

I tried again to install the preview version 0.1.16 and the install was successful. I also tried to install @rnx-kit/align-deps, did all the setup, and managed to run rnx-align-deps --write. But the issue persists.

AndrewDongminYoo commented 1 year ago

Hi, @aluxmanu

Firstly, thank you for reporting the issue. I used that command to align my dependency packages while working on this issue, and it looks like it was caused by not including it in peer dependencies or dev dependencies. Perhaps I should install the @rnx-kit/align-deps package directly into the library, similar to what you tried. I'll update and let you know as soon as I can, but if you're in a hurry for a hotfix to the library, you could try editing that part with a tool like patch-packages. Of course, pull requests are also welcome!!!

aluxmanu commented 1 year ago

@AndrewDongminYoo Hi I just tested 0.2.1 and this issue is fixed :D Other than that I still get this error. https://github.com/AndrewDongminYoo/react-native-step-counter/issues/28#issuecomment-1687579090 But we can close this one.