AndrewEllis93 / Pressure_Linear_Advance_Tool

Pressure Advance / Linear Advance Calibration Tool
https://ellis3dp.com/Print-Tuning-Guide/articles/pressure_linear_advance/introduction.html
GNU General Public License v3.0
40 stars 21 forks source link

Can't set End K value higher than 0.2 #19

Open 2probro opened 1 year ago

2probro commented 1 year ago

Describe the bug I want to use a Linear advance K-value of 1 or higher on my bowden ender 3. But set "End K value" to 1, it doesnt work anymore. The "End K value" gets highlighted in yellow and I can't download my gcode. Why is this not possible, k values for bowden setup are limited by the page to 0.2, which is too low for my printer.

Klipper Error Message (if applicable)

G-code File Not able to set my end k value, so couldn't export my gcode

Screenshots image image

2probro commented 1 year ago

The whole section for pressure advance max 0.2 should be removed:

if (!validationFail) { // only check if above checks pass // Check if PA smooth exceeds 0.2 if (config.pa_smooth && config.pa_end > 0.2){ $("label[for=PA_END]").addClass("invalid"); $("#warning1").text( "PA smooth cannot exceed 0.2." ); $("#warning1").addClass("invalid"); $("#warning1").show(); invalid = 1; validationFail = true; } }

After deleting this in "pressure_linear_advance.js?v24" I was finally able to set a value higher than 0.2 for linear advance in marlin. I can now export my gcode.

image

image

2probro commented 1 year ago

I also noticed that it says "Pa smooth" while using marlin's linear advance. This is also wrong right?

LittleNyanCat commented 1 year ago

Also having this issue, particularly annoying when the dialog box specifically recommends starting out with 1 if you have a bowden...

nesb0t commented 1 year ago

This bug was introduced here to fix #14 so simply removing the validation check isn't the right fix.

The cause was that config.pa_smooth is returning true even when you didn't turn it on. I was working on troubleshooting it so I could submit a PR but for some reason I can no longer replicate it and things are now working as expected. Ha. I have a feeling it's related to filling out the form in a particular order and something is turning that option on, but after running in to this issue repeatedly, I can't replicate it anymore so I have no idea.

If you find yourself running in to this issue and don't want to modify the js as mentioned above, an easy fix is to enable the Advanced Mode checkbox at the top and then enable and then disable Increment Smooth Time Instead under Pressure Advance Stepping. This will force the variable to false and it should generate.

LittleNyanCat commented 1 year ago

That validation should only be checked if the selected firmware is Klipper, as #14 is a Klipper-specific issue.

I'm having issues with Marlin 1.1.9+/Marlin 1.1.8 & Older selected, where there isn't a Increment Smooth Time Instead option which makes things harder.

I've resorted to setting it to Klipper, doing your workaround, messing with some of the values, switching back to Marlin and then sometimes (haven't figured out exactly what makes it happen) it starts letting me use any max PA value with Marlin selected.

msticninja commented 1 year ago

Keep Firmware type as Klipper, but enable Advanced mode with the checkbox at the top of Settings, and Uncheck "Increment Smooth Time Instead" in the PA section. Then you can use the full range of End Values without changing the firmware type. Once you find your PA, you can recheck the "Increment Smooth Time Instead" box and tune your Firmware's PA Smoothing Time.

johnquix commented 10 months ago

Still having this issue. I'm on RRF so staying in Klipper and using the work arounds doesn't work.

AndrewEllis93 commented 9 months ago

I set that validation check to only happen if Klipper is selected. Can you please see if this issue is still occurring?