search

AndrewEllis93 / Pressure_Linear_Advance_Tool

Pressure Advance / Linear Advance Calibration Tool
https://ellis3dp.com/Print-Tuning-Guide/articles/pressure_linear_advance/introduction.html
GNU General Public License v3.0
40 stars 21 forks source link

Unwanted "]" on Start Gcode klipper on pressure advance calibration tool (web) #33

Closed Mac-EvoyING closed 9 months ago

Mac-EvoyING commented 11 months ago

Bug Description An unwanted bracket is added to the hotend temperature during gcode generation, when the start gcode looks like this (focus: last 2 brackets). See screenshots:

M104 S0
M140 S0
START_PRINT HEATER_BED=[first_layer_bed_temperature] HOTEND=[first_layer_temperature[initial_extruder]]

which causes the hotend to inmediately shutdown after PA Test begins in klipper. Both bed and hotend temperatures are correctly parsed, however, the closing double brackets for the hotend seem not.

Klipper Error Message No direct klipper error message is output, but the hotend shuts down inmediately after PA Calibration test starts, leading to an "extruder below minimum temperature" error.

G-code File Unsupported file type on Github.

Screenshots image

As a workaround, by removing one of the closing brackets (which is not correct), the GCODE generator seems to work just fine. No hotend shutdowns are experienced at all.

image

AndrewEllis93 commented 9 months ago

Thanks for the pull request! I have not been keeping up here as much as I should - I fixed this after someone mentioned on Discord before seeing your PR sorry. But thank you regardless. It should be fixed now.

Whoops that comment was meant for the PR. This should be fixed in ddd57b7. Thanks for reporting it!