search

AndrewEllis93 / Print-Tuning-Guide

1.92k stars 261 forks source link

Update TEST_SPEED.cfg #120

Closed SuhbatDaRobot closed 6 hours ago

SuhbatDaRobot commented 3 months ago

Klipper no longer has a MAX_ACCEL_TO_DECEL paramter in the firmware, it has been changed to MINIMUM CRUISE RATIO.

This is a patch that works for now.

mtaumike commented 3 months ago

I was coming here to report the same

anderso commented 2 months ago

There is an open issue as well: https://github.com/AndrewEllis93/Print-Tuning-Guide/issues/119

This patch changes a lot of other stuff and there's commented out code. From briefly looking at this I'm not sure what the best solution is, I'm guessing there are no mechanisms to handle backward compatibility in klipper. Maybe setting and resetting both ACCEL_TO_DECEL and MIN_CRUISE_RATIO values should work for now? Or just assume people are using recent klipper and don't bother with ACCEL_TO_DECEL, or exit with error message if this is set in config.

In my case it errored with:

Error on 'SET_VELOCITY_LIMIT VELOCITY=200.0 ACCEL=5000.0 ACCEL_TO_DECEL=': unable to parse

Probably because printer.configfile.settings.printer.max_accel_to_decel has no value.

References:

https://www.klipper3d.org/Config_Reference.html#printer

https://www.klipper3d.org/Config_Changes.html?h=max_accel_to_decel#changes

SuhbatDaRobot commented 1 week ago

There is an open issue as well: #119

This patch changes a lot of other stuff and there's commented out code. From briefly looking at this I'm not sure what the best solution is, I'm guessing there are no mechanisms to handle backward compatibility in klipper. Maybe setting and resetting both ACCEL_TO_DECEL and MIN_CRUISE_RATIO values should work for now? Or just assume people are using recent klipper and don't bother with ACCEL_TO_DECEL, or exit with error message if this is set in config.

In my case it errored with:

Error on 'SET_VELOCITY_LIMIT VELOCITY=200.0 ACCEL=5000.0 ACCEL_TO_DECEL=': unable to parse

Probably because printer.configfile.settings.printer.max_accel_to_decel has no value.

References:

https://www.klipper3d.org/Config_Reference.html#printer

https://www.klipper3d.org/Config_Changes.html?h=max_accel_to_decel#changes

There is an open issue as well: #119

This patch changes a lot of other stuff and there's commented out code. From briefly looking at this I'm not sure what the best solution is, I'm guessing there are no mechanisms to handle backward compatibility in klipper. Maybe setting and resetting both ACCEL_TO_DECEL and MIN_CRUISE_RATIO values should work for now? Or just assume people are using recent klipper and don't bother with ACCEL_TO_DECEL, or exit with error message if this is set in config.

In my case it errored with:

Error on 'SET_VELOCITY_LIMIT VELOCITY=200.0 ACCEL=5000.0 ACCEL_TO_DECEL=': unable to parse

Probably because printer.configfile.settings.printer.max_accel_to_decel has no value.

References:

https://www.klipper3d.org/Config_Reference.html#printer

https://www.klipper3d.org/Config_Changes.html?h=max_accel_to_decel#changes

The issues mentioned by the open issue fix have been fixed in this final commit thank to Jomik's suggestions. Thank you all for your help.