AndrewFahlgren / PotionCraftUsefulRecipeMarks

0 stars 0 forks source link

Icon not found. Replaced by first #1

Closed keebisbored closed 9 months ago

keebisbored commented 1 year ago

whenever I click on a step from the potion, I get this error and the game force closes. When loading the save and opening the saved recipes tab, the error occurs immediately, Disabling the mod through thunderstore and loading that same save fixes the issue. If you want me to attach my game folder and files I can do that.

Emilgardis commented 9 months ago

I'm also experiencing this. Only this mod and Recipe Waypoints installed

AndrewFahlgren commented 9 months ago

Thanks for letting me know! Would you be able to attach your player log so I can better identify the issue? You can find it at %APPDATA%..\LocalLow\niceplay games\Potion Craft\Player.log

I am not great about checking issues here so if I don't respond right away feel free to post in the Potion Craft discord (https://discord.gg/83GQ8U9v) in the #modding channel. You can tag @Fahlgorithm and I will respond much quicker.

AndrewFahlgren commented 9 months ago

@Emilgardis See above comment

Emilgardis commented 9 months ago

Simply created a new save, skipped tutorial, 3x terraria to make strength, save recipe, take potion, open recipe, click on icon, crash with Icon not found. Replaced by first.

Mono path[0] = 'W:/SteamLibrary/steamapps/common/Potion Craft/Potion Craft_Data/Managed'
Mono config path = 'W:/SteamLibrary/steamapps/common/Potion Craft/MonoBleedingEdge/etc'
Fallback handler could not load library W:/SteamLibrary/steamapps/common/Potion Craft/Potion Craft_Data/MonoBleedingEdge/data-0000025ABCC320D0.dll
Fallback handler could not load library W:/SteamLibrary/steamapps/common/Potion Craft/Potion Craft_Data/MonoBleedingEdge/data-0000025AC283A040.dll
Initialize engine version: 2021.3.8f1 (b30333d56e81)
[Subsystems] Discovering subsystems at path W:/SteamLibrary/steamapps/common/Potion Craft/Potion Craft_Data/UnitySubsystems
GfxDevice: creating device client; threaded=1; jobified=0
Direct3D:
    Version:  Direct3D 11.0 [level 11.1]
    Renderer: NVIDIA GeForce RTX 3080 (ID=0x2206)
    Vendor:   NVIDIA
    VRAM:     10067 MB
    Driver:   31.0.15.5009
Begin MonoManager ReloadAssembly
- Completed reload, in  0.165 seconds
[Message:   BepInEx] BepInEx 5.4.18.0 - Potion Craft (1/17/2024 8:45:39 AM)
[Info   :   BepInEx] Running under Unity v2021.3.8.11731763
[Info   :   BepInEx] CLR runtime version: 4.0.30319.42000
[Info   :   BepInEx] Supports SRE: True
[Info   :   BepInEx] System platform: Bits64, Windows
[Message:   BepInEx] Preloader started
[Info   :   BepInEx] Loaded 1 patcher method from [BepInEx.Preloader 5.4.18.0]
[Info   :   BepInEx] 1 patcher plugin loaded
[Info   :   BepInEx] Patching [UnityEngine.CoreModule] with [BepInEx.Chainloader]
[Message:   BepInEx] Preloader finished
[Message:   BepInEx] Chainloader ready
[Message:   BepInEx] Chainloader started
[Info   :   BepInEx] 2 plugins to load
[Warning:   BepInEx] Plugin [PotionCraftBrewFromHere 1.1.0.0] targets a wrong version of BepInEx (5.4.20.0) and might not work until you update
[Warning:   BepInEx] Plugin [PotionCraftRecipeWaypoints 1.1.0.0] targets a wrong version of BepInEx (5.4.20.0) and might not work until you update
[Info   :   BepInEx] Loading [PotionCraftBrewFromHere 1.1.0.0]
[Info   :PotionCraftBrewFromHere] Plugin com.fahlgorithm.potioncraftbrewfromhere is loaded!
Fallback handler could not load library W:/SteamLibrary/steamapps/common/Potion Craft/Potion Craft_Data/MonoBleedingEdge/data-0000025B4AA98450.dll
[Info   :PotionCraftBrewFromHere] Plugin com.fahlgorithm.potioncraftbrewfromhere: Patch Succeeded!
[Info   :   BepInEx] Loading [PotionCraftRecipeWaypoints 1.1.0.0]
[Info   :PotionCraftRecipeWaypoints] Plugin com.fahlgorithm.potioncraftrecipewaypoints is loaded!
[Info   :PotionCraftRecipeWaypoints] Plugin com.fahlgorithm.potioncraftrecipewaypoints: Patch Succeeded!
[Message:   BepInEx] Chainloader startup complete
<RI> Initializing input.
New input system (experimental) initialized
<RI> Initialized touch support.
UnloadTime: 6.161500 ms
[Info   :PotionCraftBrewFromHere] Error: stateJsonString is empty. Cannot load data.
[Info   :PotionCraftRecipeWaypoints] Error: stateJsonString is empty. Cannot load ignored waypoints
[Message:PotionCraftBrewFromHere] ResetPotion - False - True - True
[Message:PotionCraftBrewFromHere] ResetPotion - 1
[Message:PotionCraftBrewFromHere] SetupInitialInfo
[Message:PotionCraftBrewFromHere] ResetPotion - False - True - True
[Message:PotionCraftBrewFromHere] ResetPotion - 1
[Message:PotionCraftBrewFromHere] SetupInitialInfo
PotionBottle.GetByName: No "" bottle found. Return first.
Icon  not found. Replaced by first.
PotionSticker.GetByName: No "" sticker found. Return first.
Setting up 12 worker threads for Enlighten.
Releasing render texture that is set as Camera.targetTexture!

omitted the large memory statistic dump at the end

AndrewFahlgren commented 9 months ago

@Emilgardis

Hey, it looks like there might be an issue with the version of BepInEx which could be related to this. Could you try updating to BepInEx version 5.4.20 and see if anything changes? Thanks for going through all of these steps with me by the way. This will be really useful in fixing this and making sure others don't run into this issue!

Here is the link to that version of BepInEx: https://github.com/BepInEx/BepInEx/releases/tag/v5.4.20 (be sure to download BepInEx_x64_5.4.20.0.zip)

To do the update you just need to download the new files and replace the old ones in the potion craft directory.

Emilgardis commented 9 months ago

@AndrewFahlgren same error. Also, the latest available bepinex on r2modman is 5.4.18, maybe that should be updated by whoever maintains it :3

Mono path[0] = 'W:/SteamLibrary/steamapps/common/Potion Craft/Potion Craft_Data/Managed'
Mono config path = 'W:/SteamLibrary/steamapps/common/Potion Craft/MonoBleedingEdge/etc'
Fallback handler could not load library W:/SteamLibrary/steamapps/common/Potion Craft/Potion Craft_Data/MonoBleedingEdge/data-000001E2B3114940.dll
Fallback handler could not load library W:/SteamLibrary/steamapps/common/Potion Craft/Potion Craft_Data/MonoBleedingEdge/data-000001E2B8BB3040.dll
Initialize engine version: 2021.3.8f1 (b30333d56e81)
[Subsystems] Discovering subsystems at path W:/SteamLibrary/steamapps/common/Potion Craft/Potion Craft_Data/UnitySubsystems
GfxDevice: creating device client; threaded=1; jobified=0
Direct3D:
    Version:  Direct3D 11.0 [level 11.1]
    Renderer: NVIDIA GeForce RTX 3080 (ID=0x2206)
    Vendor:   NVIDIA
    VRAM:     10067 MB
    Driver:   31.0.15.5009
Begin MonoManager ReloadAssembly
- Completed reload, in  0.204 seconds
[Message:   BepInEx] BepInEx 5.4.20.0 - Potion Craft (1/17/2024 8:45:39 AM)
[Info   :   BepInEx] Running under Unity v2021.3.8.11731763
[Info   :   BepInEx] CLR runtime version: 4.0.30319.42000
[Info   :   BepInEx] Supports SRE: True
[Info   :   BepInEx] System platform: Bits64, Windows
[Message:   BepInEx] Preloader started
[Info   :   BepInEx] Loaded 1 patcher method from [BepInEx.Preloader 5.4.20.0]
[Info   :   BepInEx] 1 patcher plugin loaded
[Info   :   BepInEx] Patching [UnityEngine.CoreModule] with [BepInEx.Chainloader]
[Message:   BepInEx] Preloader finished
[Message:   BepInEx] Chainloader ready
[Message:   BepInEx] Chainloader started
[Info   :   BepInEx] 2 plugins to load
[Info   :   BepInEx] Loading [PotionCraftBrewFromHere 1.1.0.0]
[Info   :PotionCraftBrewFromHere] Plugin com.fahlgorithm.potioncraftbrewfromhere is loaded!
Fallback handler could not load library W:/SteamLibrary/steamapps/common/Potion Craft/Potion Craft_Data/MonoBleedingEdge/data-000001E340E39850.dll
[Info   :PotionCraftBrewFromHere] Plugin com.fahlgorithm.potioncraftbrewfromhere: Patch Succeeded!
[Info   :   BepInEx] Loading [PotionCraftRecipeWaypoints 1.1.0.0]
[Info   :PotionCraftRecipeWaypoints] Plugin com.fahlgorithm.potioncraftrecipewaypoints is loaded!
[Info   :PotionCraftRecipeWaypoints] Plugin com.fahlgorithm.potioncraftrecipewaypoints: Patch Succeeded!
[Message:   BepInEx] Chainloader startup complete
<RI> Initializing input.
New input system (experimental) initialized
<RI> Initialized touch support.
UnloadTime: 1.543000 ms
[Info   :PotionCraftBrewFromHere] Error: stateJsonString is empty. Cannot load data.
[Info   :PotionCraftRecipeWaypoints] Error: stateJsonString is empty. Cannot load ignored waypoints
[Message:PotionCraftBrewFromHere] ResetPotion - False - True - True
[Message:PotionCraftBrewFromHere] ResetPotion - 1
[Message:PotionCraftBrewFromHere] SetupInitialInfo
[Message:PotionCraftBrewFromHere] ResetPotion - False - True - True
[Message:PotionCraftBrewFromHere] ResetPotion - 1
[Message:PotionCraftBrewFromHere] SetupInitialInfo
[Info   :PotionCraftRecipeWaypoints] Waypoint not added to map due to proximity to existing waypoint: New potion
[Info   :PotionCraftRecipeWaypoints] 0.7012966--16.30447
PotionBottle.GetByName: No "" bottle found. Return first.
Icon  not found. Replaced by first.
PotionSticker.GetByName: No "" sticker found. Return first.
[Info   :PotionCraftRecipeWaypoints] Waypoint not added to map due to proximity to existing waypoint: New potion
[Info   :PotionCraftRecipeWaypoints] -0.1240747--15.7636
[Info   :PotionCraftRecipeWaypoints] Waypoint not added to map due to proximity to existing waypoint: New potion
[Info   :PotionCraftRecipeWaypoints] -0.1240747--15.7636
Setting up 12 worker threads for Enlighten.
Releasing render texture that is set as Camera.targetTexture!

PS, had some trouble updating, uninstalled from r2modman but the profile it used still had the bepinex-potioncraft available so it installed 5.4.18. Fix was to simply replace <ProfileDir>/BepInEx/core with the new core folder in the github release from 5.4.20

Emilgardis commented 9 months ago

also crash without waypoint mod

Mono path[0] = 'W:/SteamLibrary/steamapps/common/Potion Craft/Potion Craft_Data/Managed'
Mono config path = 'W:/SteamLibrary/steamapps/common/Potion Craft/MonoBleedingEdge/etc'
Fallback handler could not load library W:/SteamLibrary/steamapps/common/Potion Craft/Potion Craft_Data/MonoBleedingEdge/data-0000028640837DD0.dll
Fallback handler could not load library W:/SteamLibrary/steamapps/common/Potion Craft/Potion Craft_Data/MonoBleedingEdge/data-000002864631D040.dll
Initialize engine version: 2021.3.8f1 (b30333d56e81)
[Subsystems] Discovering subsystems at path W:/SteamLibrary/steamapps/common/Potion Craft/Potion Craft_Data/UnitySubsystems
GfxDevice: creating device client; threaded=1; jobified=0
Direct3D:
    Version:  Direct3D 11.0 [level 11.1]
    Renderer: NVIDIA GeForce RTX 3080 (ID=0x2206)
    Vendor:   NVIDIA
    VRAM:     10067 MB
    Driver:   31.0.15.5009
Begin MonoManager ReloadAssembly
- Completed reload, in  0.165 seconds
[Message:   BepInEx] BepInEx 5.4.20.0 - Potion Craft (1/17/2024 8:45:39 AM)
[Info   :   BepInEx] Running under Unity v2021.3.8.11731763
[Info   :   BepInEx] CLR runtime version: 4.0.30319.42000
[Info   :   BepInEx] Supports SRE: True
[Info   :   BepInEx] System platform: Bits64, Windows
[Message:   BepInEx] Preloader started
[Info   :   BepInEx] Loaded 1 patcher method from [BepInEx.Preloader 5.4.20.0]
[Info   :   BepInEx] 1 patcher plugin loaded
[Info   :   BepInEx] Patching [UnityEngine.CoreModule] with [BepInEx.Chainloader]
[Message:   BepInEx] Preloader finished
[Message:   BepInEx] Chainloader ready
[Message:   BepInEx] Chainloader started
[Info   :   BepInEx] 1 plugins to load
[Info   :   BepInEx] Loading [PotionCraftBrewFromHere 1.1.0.0]
[Info   :PotionCraftBrewFromHere] Plugin com.fahlgorithm.potioncraftbrewfromhere is loaded!
Fallback handler could not load library W:/SteamLibrary/steamapps/common/Potion Craft/Potion Craft_Data/MonoBleedingEdge/data-00000286CE56B020.dll
[Info   :PotionCraftBrewFromHere] Plugin com.fahlgorithm.potioncraftbrewfromhere: Patch Succeeded!
[Message:   BepInEx] Chainloader startup complete
<RI> Initializing input.
New input system (experimental) initialized
<RI> Initialized touch support.
UnloadTime: 1.441800 ms
[Info   :PotionCraftBrewFromHere] Error: stateJsonString is empty. Cannot load data.
[Message:PotionCraftBrewFromHere] ResetPotion - False - True - True
[Message:PotionCraftBrewFromHere] ResetPotion - 1
[Message:PotionCraftBrewFromHere] SetupInitialInfo
[Message:PotionCraftBrewFromHere] ResetPotion - False - True - True
[Message:PotionCraftBrewFromHere] ResetPotion - 1
[Message:PotionCraftBrewFromHere] SetupInitialInfo
PotionBottle.GetByName: No "" bottle found. Return first.
Icon  not found. Replaced by first.
PotionSticker.GetByName: No "" sticker found. Return first.
Setting up 12 worker threads for Enlighten.
Releasing render texture that is set as Camera.targetTexture!
AndrewFahlgren commented 9 months ago

This crash was reproduced when only this mod was installed with none of my other mods. In order to fix it I copied a couple patches from my other mods so this mod can work even when installed on its own.

https://github.com/AndrewFahlgren/PotionCraftUsefulRecipeMarks/commit/5c1292c283781f30872aa72f36d871ad1b75fc13