search

AndrewIngram / django-extra-views

Django's class-based generic views are awesome, let's have more of them.
MIT License
1.38k stars 172 forks source link

Complete Messages Mixin #184

Closed sdolemelipone closed 5 years ago

sdolemelipone commented 5 years ago

This replaces PR #147 and uses most of what @freeworlder did. I have added documentation and updated the tests.

One change I made was to add inlines to the arguments of SuccessMessageMixin.get_success_message() so that they can be used in the success message. This seemed in line with what was discussed in #59.

Apologies that the commit history is a little messy, am happy to clean it up if requested.

codecov-io commented 5 years ago

Codecov Report

Merging #184 into master will decrease coverage by 0.12%. The diff coverage is 47.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   50.88%   50.75%   -0.13%     
==========================================
  Files           6        6              
  Lines         509      530      +21     
  Branches       56       58       +2     
==========================================
+ Hits          259      269      +10     
- Misses        234      243       +9     
- Partials       16       18       +2
Impacted Files Coverage Δ
extra_views/__init__.py 0% <ø> (ø) :arrow_up:
extra_views/advanced.py 53.98% <47.61%> (-1.46%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dea506a...4005de9. Read the comment docs.

jonashaag commented 5 years ago

Otherwise looks very good to me!