Closed therefromhere closed 4 years ago
I'm not sure why some of the tests are failing on travis, tox is passing for me locally.
It seems to be something specific to Django>=2.2, maybe something subtly wrong with the settings setup in runtests.py? I'd be tempted to remove nose/runtests.py and see if it goes away with pytest-django and a more normal settings file in tests/settings.py.
(for what it's worth I'm using django-extra-views with Django 2.2 in prod with no issues).
If we can easily get rid of nose I'm all for it.
I think it's because of this from django.contrib.contenttypes.models import ContentType
in extra_views_tests/models.py
.
Also there are no migrations for the extra_views_tests models.
Merging #197 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #197 +/- ##
=======================================
Coverage 83.93% 83.93%
=======================================
Files 4 4
Lines 386 386
Branches 48 48
=======================================
Hits 324 324
Misses 48 48
Partials 14 14
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 98b1121...d4d1d6e. Read the comment docs.
I've fixed the tests, the failure was because extra_views_tests has models but didn't have migrations. No idea why it was passing locally and failing on travis though. Should be all good now.
Boy these codecov comments are annoying
Thanks!
Resolves #196