search

AndrewIngram / django-extra-views

Django's class-based generic views are awesome, let's have more of them.
MIT License
1.39k stars 172 forks source link

Switch from nose to pytest-django #200

Closed therefromhere closed 5 years ago

therefromhere commented 5 years ago

I noticed that coverage has increased dramatically, though the tests haven't changed - it seems from looking at

before https://codecov.io/gh/AndrewIngram/django-extra-views/src/3df3a74720524d738b05dbcc6e881aa79957ceec/extra_views/contrib/mixins.py

vs after

https://codecov.io/gh/AndrewIngram/django-extra-views/src/6308cb06b21eb96afb0694d02705c260e1136e36/extra_views/contrib/mixins.py

that the top level code imports etc is counted as covered by pytest but not by nose?

codecov-io commented 5 years ago

Codecov Report

Merging #200 into master will increase coverage by 32.99%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #200       +/-   ##
===========================================
+ Coverage   50.93%   83.93%   +32.99%     
===========================================
  Files           6        4        -2     
  Lines         532      386      -146     
  Branches       58       48       -10     
===========================================
+ Hits          271      324       +53     
+ Misses        243       48      -195     
+ Partials       18       14        -4
Impacted Files Coverage Δ
extra_views/__init__.py
extra_views/formsets.py
extra_views/dates.py 66.66% <0%> (+23.07%) :arrow_up:
extra_views/contrib/mixins.py 92.06% <0%> (+33.33%) :arrow_up:
extra_views/advanced.py 93.91% <0%> (+39.13%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ef33490...6308cb0. Read the comment docs.

jonashaag commented 5 years ago

Well it’s only a one-off difference so never mind