search

AndrewIngram / django-extra-views

Django's class-based generic views are awesome, let's have more of them.
MIT License
1.39k stars 172 forks source link

Remove warnings/deprecations #223

Closed sdolemelipone closed 3 years ago

sdolemelipone commented 3 years ago

Probably time for a release to keep the project alive :-)

jonashaag commented 3 years ago

Thanks!

I would postpone the release until we have some actual changes to be released. Right now we would only make the lives of 2.7 people harder for no benefit to anyone

sdolemelipone commented 3 years ago

Ok! I thought that a project without a release in more than a year would appear unmaintained. But what you say also makes sense r.e. 2.7.

sdolemelipone commented 3 years ago

@jonashaag I will remove the release part of the PR if you'd still like to merge in the removal of the deprecated classes?

codecov-io commented 3 years ago

Codecov Report

Merging #223 (c903abe) into master (f580e8b) will increase coverage by 1.79%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
+ Coverage   83.64%   85.43%   +1.79%     
==========================================
  Files           4        4              
  Lines         379      364      -15     
  Branches       48       48              
==========================================
- Hits          317      311       -6     
+ Misses         48       39       -9     
  Partials       14       14
Impacted Files Coverage Δ
extra_views/advanced.py 96.29% <ø> (+2.49%) :arrow_up:
extra_views/generic.py 100.00% <ø> (+22.22%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f580e8b...c903abe. Read the comment docs.