search

AndrewIngram / django-extra-views

Django's class-based generic views are awesome, let's have more of them.
MIT License
1.39k stars 172 forks source link

Release 0.14.0 for missing six dependency #230

Closed sdolemelipone closed 3 years ago

sdolemelipone commented 3 years ago

Version 0.13.0 has a dependency on the six package in extra_views/contrib/mixins.py, but six is not listed as a dependency in setup.py. This causes a ModuleNotFound error if six is not installed manually/by another package.

Commit 4a91620c490b0944b4c84528a8625e057727b4a1 removed the dependency on six, so it's just a matter of performing a release.

codecov-commenter commented 3 years ago

Codecov Report

Merging #230 (207459a) into master (d081879) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #230   +/-   ##
=======================================
  Coverage   88.77%   88.77%           
=======================================
  Files           6        6           
  Lines         490      490           
  Branches       54       54           
=======================================
  Hits          435      435           
  Misses         40       40           
  Partials       15       15
Impacted Files Coverage Δ
extra_views/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d081879...207459a. Read the comment docs.

jonashaag commented 3 years ago

Released!

sdolemelipone commented 3 years ago

Whoop! Thanks.