search

AndrewIngram / django-extra-views

Django's class-based generic views are awesome, let's have more of them.
MIT License
1.39k stars 172 forks source link

Switch from travis to github actions #235

Closed sdolemelipone closed 3 years ago

sdolemelipone commented 3 years ago

Have used ymyzk/tox-gh-actions to allow a single tox configuration file be used for for local tox and CI tests.

Modified the djangomaster tox runs to return a success result even when the tests fail. The failing tests will still be visible in the output from tox.

After this has been merged I'll raise a further PR to incorporate the lint runs into the CI (currently they would fail due to configuration issues and a couple of files failing on isort).

jonashaag commented 3 years ago

This is great! LGTM. I wonder if using floating point versions (as opposed to string versions: "3.5") will cause trouble but it's used that way in the tox-gh-actions repo as well so should be fine.

sdolemelipone commented 3 years ago

:+1: Great! Will raise the next pull request for linting shortly. Yes I tested this with floating point on my repo first and it worked fine.