search

AndrewIngram / django-extra-views

Django's class-based generic views are awesome, let's have more of them.
MIT License
1.38k stars 172 forks source link

Add linting to github workflow and added separate tox steps #236

Closed sdolemelipone closed 3 years ago

sdolemelipone commented 3 years ago

Added single definition for latest python version in github actions.

Separate steps for linting give better feedback to indicate what's failing. Added .venv and venv to .gitignore and defaults to help with user virtual env setups.

CI for this will fail, after this I will submit a second commit to fix the lint issues which occur.

codecov-commenter commented 3 years ago

Codecov Report

Merging #236 (5603ae9) into master (bd2399b) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #236   +/-   ##
=======================================
  Coverage   88.77%   88.77%           
=======================================
  Files           6        6           
  Lines         490      490           
  Branches       54       54           
=======================================
  Hits          435      435           
  Misses         40       40           
  Partials       15       15
Impacted Files Coverage Δ
extra_views/dates.py 66.37% <ø> (ø)
extra_views/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bd2399b...5603ae9. Read the comment docs.

jonashaag commented 3 years ago

This is great!