AndrewIngram / django-extra-views

Django's class-based generic views are awesome, let's have more of them.
MIT License
1.38k stars 172 forks source link

setting “python_requires” with ">=3.5" is a better way to declare Python compatibility #253

Open PyVCEchecker opened 1 year ago

PyVCEchecker commented 1 year ago

Hello! I notice that the dependency of this distribution

install_requires=["Django >=2.1"]

I found that Django>=2.1 requires Python>=3.5 , and you declare supported python:3.5+ in README. I guess you want to set python>=3.5. But I think it is a better way to declare Python compatibility by using the keyword argument python_requires than declaring that in README.rst:

Way to improve: modify setup() in setup.py, add python_requires keyword argument:

setup(…
     python_requires=">=3.5",
     …)

Thanks for your attention. Best regrads, PyVCEchecker

jonashaag commented 1 year ago

Thanks, can you create a PR?