search

AndrewIngram / django-extra-views

Django's class-based generic views are awesome, let's have more of them.
MIT License
1.38k stars 172 forks source link

Add Python 3.11 #258

Closed sdolemelipone closed 1 year ago

sdolemelipone commented 1 year ago

Also corrected obselete whitelist_externals tox flag to allowlist_externals.

codecov-commenter commented 1 year ago

Codecov Report

Base: 85.43% // Head: 88.77% // Increases project coverage by +3.33% :tada:

Coverage data is based on head (a03e430) compared to base (84fa1ea). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #258 +/- ## ========================================== + Coverage 85.43% 88.77% +3.33% ========================================== Files 4 6 +2 Lines 364 490 +126 Branches 48 54 +6 ========================================== + Hits 311 435 +124 - Misses 39 40 +1 - Partials 14 15 +1 ``` | [Impacted Files](https://codecov.io/gh/AndrewIngram/django-extra-views/pull/258?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [extra\_views/formsets.py](https://codecov.io/gh/AndrewIngram/django-extra-views/pull/258?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZXh0cmFfdmlld3MvZm9ybXNldHMucHk=) | `98.33% <0.00%> (ø)` | | | [extra\_views/\_\_init\_\_.py](https://codecov.io/gh/AndrewIngram/django-extra-views/pull/258?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZXh0cmFfdmlld3MvX19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

sdolemelipone commented 1 year ago

FYI I've removed 3.5, 3.6 because they were no longer supported by the automated test suite tools (being obselete).

jonashaag commented 1 year ago

Is there an easy way to keep testing the old versions, eg. by pinning the testing tools to an older version? I’m in favor of keeping compat if it doesn’t cost a lot of effort.

sdolemelipone commented 1 year ago

Yep I can see what's possible. I won't be able to do much for the next week as I'm on holiday with poor internet connection, but can pick it up when I get back.

sdolemelipone commented 1 year ago

Forcing the runner use ubuntu 20.04 rather than 22.04 allowed the tests to still run for Python 3.5+ :-) This should work fine until a new version of python is released which ubuntu 20.04 does not support.