search

AndrewIngram / django-extra-views

Django's class-based generic views are awesome, let's have more of them.
MIT License
1.39k stars 172 forks source link

SearchableListMixin should manage form #260

Open typonaut opened 1 year ago

typonaut commented 1 year ago

It seems to me that if you are going to have a SearchableListMixin, then that Mixin should also deal with any form input required for the search. ie there should be a form_class property.

sdolemelipone commented 1 year ago

contrib.SearchableListMixin hasn't received a lot of maintenance over the years... probably django-filter deals with this much better now. Are you using the mixin? Feel free to submit a pull request if that change would be useful, it sounds reasonable.