AndrewKeepCoding / AK.Toolkit

The AK.Toolkit will be a collection of controls, helpers, etc... stuff that I needed to use but couldn't find somewhere else.
MIT License
43 stars 6 forks source link

Dark theme issue #5

Closed ghost1372 closed 2 years ago

ghost1372 commented 2 years ago

Hi again, foreground needs to be updated

Untitled

AndrewKeepCoding commented 2 years ago

If you don't set the SuggestionForeground, it uses the placeholder default foreground. I guess I can to add this option on the demo tonight. Thanks!

ghost1372 commented 2 years ago

hmm... in Light Mode foreground is correct normal mode:

1

autocomplete mode 2

suggestion foreground color matches the Placeholder foreground.👌

but in dark mode suggestion foreground color is different from Placeholder foreground color

normal mode is correct: 3

autocomplete mode

4

as you can see suggestion foreground color is black and we cant easily see it. So I think this is a problem and needs to be fixed

AndrewKeepCoding commented 2 years ago

This is how it looks on my laptop. The placeholder foreground (TextControlPlaceholderForeground) is used.

image

I'm not sure the difference but at least changing the SuggestionForeground works in your environment, right? 🤔

ghost1372 commented 2 years ago

This is strange. I know we can use SuggestionForeground property, but by default the colors should be appropriate

AndrewKeepCoding commented 2 years ago

Yeah very strange. And I totally agree with you. That's why I used the theme resource TextControlPlaceholderForeground in the first place. I guess I need to learn more about the difference themes can make...🙄

ghost1372 commented 2 years ago

take a look at here mybe can help

ghost1372 commented 2 years ago

i fixed this issue by using SystemColorGrayTextColor #7

AndrewKeepCoding commented 2 years ago

@ghost1372 Thanks for the PRs! 😎