AndrewPaglusch / FlashPaper

One-time encrypted password/secret sharing
MIT License
353 stars 57 forks source link

Ghost #129

Closed bleach86 closed 1 year ago

bleach86 commented 1 year ago

ready

AndrewPaglusch commented 1 year ago

@bleach86 Thank you for your interest in contributing to this project. We appreciate your effort and the time you've put into preparing the pull request.

However, I've noticed that you've added your name to the copyright notice in the MIT License. Even though the MIT License permits forking, modifying, and distributing the code, it doesn't authorize altering the original copyright notice. Even in your fork, you may not modify the original copyright notice. The name of the copyright holder and the year should remain intact in the license file of the forked repository.

Contributions to the project, regardless of their size, are absolutely valuable, and we want to ensure every contributor receives the recognition they deserve. To that end, we typically acknowledge contributors in the change logs.

For now, I'll need you to remove your name from the copyright notice in the license file if you open this PR back up. Please also squash your commits and add a description of what your pull request is changing before we consider reviewing and merging it. Thank you!

bleach86 commented 1 year ago

@bleach86 Thank you for your interest in contributing to this project. We appreciate your effort and the time you've put into preparing the pull request.

However, I've noticed that you've added your name to the copyright notice in the MIT License. Even though the MIT License permits forking, modifying, and distributing the code, it doesn't authorize altering the original copyright notice. Even in your fork, you may not modify the original copyright notice. The name of the copyright holder and the year should remain intact in the license file of the forked repository.

Contributions to the project, regardless of their size, are absolutely valuable, and we want to ensure every contributor receives the recognition they deserve. To that end, we typically acknowledge contributors in the change logs.

For now, I'll need you to remove your name from the copyright notice in the license file if you open this PR back up. Please also squash your commits and add a description of what your pull request is changing before we consider reviewing and merging it. Thank you!

Sorry for the mixup, but I was not meaning to do a pull request to this repo, but within my own. I did not remove your notice, only added my own in addition.

AndrewPaglusch commented 1 year ago

@bleach86 Thanks for your quick response! It's important to clarify that even when modifications are made to the project, the original copyright notice of the MIT License should remain unchanged. This includes adding new names alongside the original copyright holder's.

While I completely acknowledge and appreciate your contributions to this project, the copyright holder of the source code remains the same. The nature of open source allows for modification of the code but not the alteration of the original copyright notice.

I hope you understand and respect these guidelines. Thank you for your cooperation.

bleach86 commented 1 year ago

@bleach86 Thanks for your quick response! It's important to clarify that even when modifications are made to the project, the original copyright notice of the MIT License should remain unchanged. This includes adding new names alongside the original copyright holder's. While I completely acknowledge and appreciate your contributions to this project, the copyright holder of the source code remains the same. The nature of open source allows for modification of the code but not the alteration of the original copyright notice. I hope you understand and respect these guidelines. Thank you for your cooperation.

I've removed it.

AndrewPaglusch commented 1 year ago

@bleach86 Thank you very much!

On Thu, Jun 29, 2023, 1:19 PM bleach86 @.***> wrote:

@bleach86 https://github.com/bleach86 Thanks for your quick response! It's important to clarify that even when modifications are made to the project, the original copyright notice of the MIT License should remain unchanged. This includes adding new names alongside the original copyright holder's. While I completely acknowledge and appreciate your contributions to this project, the copyright holder of the source code remains the same. The nature of open source allows for modification of the code but not the alteration of the original copyright notice. I hope you understand and respect these guidelines. Thank you for your cooperation.

I've removed it.

— Reply to this email directly, view it on GitHub https://github.com/AndrewPaglusch/FlashPaper/pull/129#issuecomment-1613599414, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACNSHWO3PRC7JQ7QYMJQUPLXNXBLRANCNFSM6AAAAAAZYXP2NY . You are receiving this because you commented.Message ID: @.***>

bleach86 commented 1 year ago

@bleach86 Thank you very much! On Thu, Jun 29, 2023, 1:19 PM bleach86 @.> wrote: @bleach86 https://github.com/bleach86 Thanks for your quick response! It's important to clarify that even when modifications are made to the project, the original copyright notice of the MIT License should remain unchanged. This includes adding new names alongside the original copyright holder's. While I completely acknowledge and appreciate your contributions to this project, the copyright holder of the source code remains the same. The nature of open source allows for modification of the code but not the alteration of the original copyright notice. I hope you understand and respect these guidelines. Thank you for your cooperation. I've removed it. — Reply to this email directly, view it on GitHub <#129 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACNSHWO3PRC7JQ7QYMJQUPLXNXBLRANCNFSM6AAAAAAZYXP2NY . You are receiving this because you commented.Message ID: @.>

np, thanks for making some cool software.

AndrewPaglusch commented 1 year ago

You're welcome! I'm really happy to hear that you like it.

On Thu, Jun 29, 2023, 1:50 PM bleach86 @.***> wrote:

@bleach86 https://github.com/bleach86 Thank you very much! … <#m8727498948333608729> On Thu, Jun 29, 2023, 1:19 PM bleach86 @.> wrote: @bleach86 https://github.com/bleach86 https://github.com/bleach86 https://github.com/bleach86 Thanks for your quick response! It's important to clarify that even when modifications are made to the project, the original copyright notice of the MIT License should remain unchanged. This includes adding new names alongside the original copyright holder's. While I completely acknowledge and appreciate your contributions to this project, the copyright holder of the source code remains the same. The nature of open source allows for modification of the code but not the alteration of the original copyright notice. I hope you understand and respect these guidelines. Thank you for your cooperation. I've removed it. — Reply to this email directly, view it on GitHub <#129 (comment) https://github.com/AndrewPaglusch/FlashPaper/pull/129#issuecomment-1613599414>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACNSHWO3PRC7JQ7QYMJQUPLXNXBLRANCNFSM6AAAAAAZYXP2NY https://github.com/notifications/unsubscribe-auth/ACNSHWO3PRC7JQ7QYMJQUPLXNXBLRANCNFSM6AAAAAAZYXP2NY . You are receiving this because you commented.Message ID: @.>

np, thanks for making some cool software.

— Reply to this email directly, view it on GitHub https://github.com/AndrewPaglusch/FlashPaper/pull/129#issuecomment-1613633877, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACNSHWJXBYKDNL7NICF5IVTXNXFA7ANCNFSM6AAAAAAZYXP2NY . You are receiving this because you commented.Message ID: @.***>