search

AndrewParkes / BlockAllSteamInvites

Steam browser script to block certain friend invites
4 stars 0 forks source link

Another suggestion :D #2

Closed EnricoBara closed 9 years ago

EnricoBara commented 9 years ago

Hi again :) Hope you glad to see me again :P

I have another, maybe more difficult suggestion :) In the last days your extension doesn't removes all the scammer, nothing wrong in your extension but I'm asking if you can search on comments of a profile if "-rep" or "scammer" words are there and block or ignore this profiles.

See you soon!

AndrewParkes commented 9 years ago

I have been thinking of trying to add something like this. The only problem is the way in which I check the profiles id does not bring up all the information of the user. It does not show comments or friends or other important information. If you want to see the information I am using in your browser go to http://steamcommunity.com/profiles/*STEAMID*?xml=1 for example my profile: http://steamcommunity.com/profiles/76561197986192443 ?xml=1. There you can see all the details that I am working with

EnricoBara commented 9 years ago

Oh I thought about a similar problem. So the only way should be tell tampermonkey to open their profile and check if in the html there are words "-rep" or "scammer" or "bot" but I don't think if tampermonkey can do this without opening a real page in chrome. Thank you for your fast reply as always

| enrico baravelli

2015-07-03 7:37 GMT+02:00 AndrewParkes notifications@github.com:

I have been thinking of trying to add something like this. The only problem is the way in which I check the profiles id does not bring up all the information of the user. It does not show comments or friends or other important information. If you want to see the information I am using in your browser go to http://steamcommunity.com/profiles/*STEAMID*?xml=1 for example my profile: http://steamcommunity.com/profiles/76561197986192443 ?xml=1. There you can see all the details that I am working with

— Reply to this email directly or view it on GitHub https://github.com/AndrewParkes/BlockAllSteamInvites/issues/2#issuecomment-118240890 .

AndrewParkes commented 9 years ago

I have a website stripper that gathers information about a website by doing a dump of the sites information of a specific webpage but in java. I will see if there is a similar way to do this in javascript or a way that tamperMonkey can make use of it and get back to you when I get a chance.

Thanks for the suggestions

EnricoBara commented 9 years ago

It could be very nice and useful!

Hope to see you soon with great news

| enrico baravelli

2015-07-03 9:56 GMT+02:00 AndrewParkes notifications@github.com:

I have a website stripper that gathers information about a website by doing a dump of the sites information of a specific webpage but in java. I will see if there is a similar way to do this in javascript or a way that tamperMonkey can make use of it and get back to you when I get a chance.

Thanks for the suggestions

— Reply to this email directly or view it on GitHub https://github.com/AndrewParkes/BlockAllSteamInvites/issues/2#issuecomment-118268338 .

AndrewParkes commented 9 years ago

I may have found a way to find out information from the comments. Can you suggest some examples of what should be flagged. eg -rep and scammer and bot. Any others you can think of?

Would you suggest if there are more than 5 occurrences of the banned words then you block the user or would you suggest a different way?

EnricoBara commented 9 years ago

I think this 3 are enought

Il sabato 4 luglio 2015, AndrewParkes notifications@github.com ha scritto:

I may have found a way to find out information from the comments. Can you suggest some examples of what should be flagged. eg -rep and scammer and bot. Any others you can think of?

— Reply to this email directly or view it on GitHub https://github.com/AndrewParkes/BlockAllSteamInvites/issues/2#issuecomment-118497458 .

| enrico baravelli

AndrewParkes commented 9 years ago

I think I have implemented it on a local copy. I will upload it soon. But once again it is a little hard to test this. Please let me know if it doesnt work and ill try fix the errors

EnricoBara commented 9 years ago

Sorry but it doesn't works. I have 2 requests with "-rep" and "scammer" in comments but when I click on bad comments the button stay blue and the page crashes

AndrewParkes commented 9 years ago

Also check it should be working. bad rep - good reps if that is greater than 3 it will be blocked. If you can send the steamid of the user I'll check why

Thanks for testing

EnricoBara commented 9 years ago

One steam id is this http://steamcommunity.com/profiles/76561198080442881 the other is http://steamcommunity.com/id/Panda322434

But please make it also available for someone who have only 1 bad comment.

| enrico baravelli

2015-07-05 18:35 GMT+02:00 AndrewParkes notifications@github.com:

Also check it should be working. bad rep - good reps if that is greater than 3 it will be blocked. If you can send the steamid of the user I'll check why

Thanks for testing

— Reply to this email directly or view it on GitHub https://github.com/AndrewParkes/BlockAllSteamInvites/issues/2#issuecomment-118636980 .

AndrewParkes commented 9 years ago

It should be fixed. Try again when you get a chance

EnricoBara commented 9 years ago

It works perfectly well done! Remember to update the version to 0.12 before pushing the update!

| enrico baravelli

2015-07-05 20:37 GMT+02:00 AndrewParkes notifications@github.com:

It should be fixed. Try again when you get a chance

— Reply to this email directly or view it on GitHub https://github.com/AndrewParkes/BlockAllSteamInvites/issues/2#issuecomment-118649339 .

AndrewParkes commented 9 years ago

Sorry forgot about that. Glad it works. Let me know if you have anymore suggestions or something stops working again.

EnricoBara commented 9 years ago

Yeah for something it works... I don't know why this private profile isn't removed http://steamcommunity.com/profiles/76561198141008467

And this have -rep on comment but it isn't removed http://steamcommunity.com/profiles/76561198040315231/

| enrico baravelli

2015-07-05 22:00 GMT+02:00 AndrewParkes notifications@github.com:

Sorry forgot about that. Glad it works. Let me know if you have anymore suggestions or something stops working again.

— Reply to this email directly or view it on GitHub https://github.com/AndrewParkes/BlockAllSteamInvites/issues/2#issuecomment-118661873 .

AndrewParkes commented 9 years ago

I'm not sure why the private profile is not being removed but I'll investigate in the morning. With the comments there has to be at least 3 bad comments for it to be seen as a scammer. Otherwise it would block anyone with a single bad comment.

EnricoBara commented 9 years ago

Why not just block if any of the comments has a "bad" word?

| enrico baravelli

2015-07-05 23:24 GMT+02:00 AndrewParkes notifications@github.com:

I'm not sure why the private profile is not being removed but I'll investigate in the morning. With the comments there has to be at least 3 bad comments for it to be seen as a scammer. Otherwise it would block anyone with a single bad comment.

— Reply to this email directly or view it on GitHub https://github.com/AndrewParkes/BlockAllSteamInvites/issues/2#issuecomment-118668463 .

AndrewParkes commented 9 years ago

For something like my profile if someone doesn't like 1 of my trades and gives me a - rep doesn't mean I am a scammed. If I have a couple of - reps or scams in my comments then you have a better chance of saying I am a scammer

EnricoBara commented 9 years ago

Yes but if you aren't a bot you will remove the comment, if you are a bot you will never remove the comment :)

| enrico baravelli

2015-07-05 23:31 GMT+02:00 AndrewParkes notifications@github.com:

For something like my profile if someone doesn't like 1 of my trades and gives me a - rep doesn't mean I am a scammed. If I have a couple of - reps or scams in my comments then you have a better chance of saying I am a scammer

— Reply to this email directly or view it on GitHub https://github.com/AndrewParkes/BlockAllSteamInvites/issues/2#issuecomment-118668772 .

EnricoBara commented 9 years ago

I also found "spam" and "scam" as bad words

| enrico baravelli

2015-07-05 23:33 GMT+02:00 Enrico Baravelli enrico.baravelli@gmail.com:

Yes but if you aren't a bot you will remove the comment, if you are a bot you will never remove the comment :)

| enrico baravelli

2015-07-05 23:31 GMT+02:00 AndrewParkes notifications@github.com:

For something like my profile if someone doesn't like 1 of my trades and gives me a - rep doesn't mean I am a scammed. If I have a couple of - reps or scams in my comments then you have a better chance of saying I am a scammer

— Reply to this email directly or view it on GitHub https://github.com/AndrewParkes/BlockAllSteamInvites/issues/2#issuecomment-118668772 .

AndrewParkes commented 9 years ago

ill add those in

EnricoBara commented 9 years ago

You are right if someone has got a -rep isn't a scammer for sure, but a scammer hasn't got any +rep comment! So I solved some of the unblocked problems modifying the badcomments in this way

            var goodComments=(comments.split("+REP").length -

1)+(comments.split("+ REP").length - 1)+(comments.split("GOOD TRADER").length - 1); var badComments=(comments.split("-REP").length - 1)+(comments.split("- REP").length - 1)+(comments.split("SCAM").length - 1)+(comments.split("PHISH").length - 1)+(comments.split("BOT").length - 1)+(comments.split("SPAM").length - 1)+(comments.split("SCAMMER").length - 1); if (goodComments>=1){}else if(badComments>=1) { FriendAccept(userAccount , 'block'); }

Do you think is it a good way?

| enrico baravelli

2015-07-06 13:59 GMT+02:00 AndrewParkes notifications@github.com:

ill add those in

— Reply to this email directly or view it on GitHub https://github.com/AndrewParkes/BlockAllSteamInvites/issues/2#issuecomment-118832935 .

AndrewParkes commented 9 years ago

Thats why I have if(badComments-goodComments>=3) because then they have to have more bad comments than good comments to be blocked

EnricoBara commented 9 years ago

Yes but it doesn't blocks who have 1 bad comment and 0 good comments :) With my modification who have 0good comment and only 1 bad comment it will be blocked, but he MUST have 0 good comments!

Anyway... I can't understand why http://steamcommunity.com/profiles/76561198036084371?xml=1 isn't blocked... it's private...

| enrico baravelli

2015-07-06 15:25 GMT+02:00 AndrewParkes notifications@github.com:

Thats why I have if(badComments-goodComments>=3) because then they have to have more bad comments than good comments

— Reply to this email directly or view it on GitHub https://github.com/AndrewParkes/BlockAllSteamInvites/issues/2#issuecomment-118853266 .

AndrewParkes commented 9 years ago

Yes and no. It could be just a new account with a person that doesnt really know what to do. I rather give then the benefit of the doubt in terms of bad comments.

The guy not getting blocked is weird ill have to do a little testing to figure out why he isnt being blocked

EnricoBara commented 9 years ago

Ok you're right.

This profiles aren't blocked too

http://steamcommunity.com/id/kleshnya42gg http://steamcommunity.com/profiles/76561198077663113

| enrico baravelli

2015-07-06 15:34 GMT+02:00 AndrewParkes notifications@github.com:

Yes and no. It could be just a new account with a person that doesnt really know what to do. I rather give then the benefit of the doubt in terms of bad comments.

The guy not getting blocked is weird ill have to do a little testing to figure out why he isnt being blocked

— Reply to this email directly or view it on GitHub https://github.com/AndrewParkes/BlockAllSteamInvites/issues/2#issuecomment-118855743 .

EnricoBara commented 9 years ago

Oh I made a mistake! Adding a goodcomment string I copied "+" 2 times and the script stopped working :)

FYI I added NICE TRADER and GOOD TRADER

| enrico baravelli

2015-07-06 15:51 GMT+02:00 Enrico Baravelli enrico.baravelli@gmail.com:

Ok you're right.

This profiles aren't blocked too

http://steamcommunity.com/id/kleshnya42gg http://steamcommunity.com/profiles/76561198077663113

| enrico baravelli

2015-07-06 15:34 GMT+02:00 AndrewParkes notifications@github.com:

Yes and no. It could be just a new account with a person that doesnt really know what to do. I rather give then the benefit of the doubt in terms of bad comments.

The guy not getting blocked is weird ill have to do a little testing to figure out why he isnt being blocked

— Reply to this email directly or view it on GitHub https://github.com/AndrewParkes/BlockAllSteamInvites/issues/2#issuecomment-118855743 .

AndrewParkes commented 9 years ago

Problem with adding good and nice trader is often they say something like +rep good trader and it will double count the goods thats why I only have +rep

EnricoBara commented 9 years ago

Hi, I don't understand why some contacts are blocked but they are good!

Like this http://steamcommunity.com/id/kmlrmdhn

and this (my second account) http://steamcommunity.com/profiles/76561198094924361

| enrico baravelli

2015-07-06 16:35 GMT+02:00 AndrewParkes notifications@github.com:

Problem with adding good and nice trader is often they say something like +rep good trader and it will double count the goods thats why I only have +rep

— Reply to this email directly or view it on GitHub https://github.com/AndrewParkes/BlockAllSteamInvites/issues/2#issuecomment-118874466 .

AndrewParkes commented 9 years ago

I cannot see why they are being blocked. I will look this weekend to see what is wrong I suggest not using the script till i can fix it

EnricoBara commented 9 years ago

Absolutely :) I'll wait for you thanks!

| enrico baravelli

2015-07-09 15:40 GMT+02:00 AndrewParkes notifications@github.com:

I cannot see why they are being blocked. I will look this weekend to see what is wrong I suggest not using the script till i can fix it

— Reply to this email directly or view it on GitHub https://github.com/AndrewParkes/BlockAllSteamInvites/issues/2#issuecomment-119969712 .

AndrewParkes commented 9 years ago

I cannot see any reason why it is not block certain users for you and blocking the wrong users. Please try delete it completely and reinstalling

AndrewParkes commented 9 years ago

I think I know why the script doesnt work on your side. If you have changed your script to (comments.split("BOT").length) from (comments.split(" BOT ").length) with spaces it picks up all occurrences of BOT in any word for example the following words are found and counted as bot: bottom (4 times), bottomsubmenu, both(3 times). Thus finding 8 BOT comments in the comments section due to me not checking the actual comments correctly yet but rather the source of the entire comments page currently

EnricoBara commented 9 years ago

Oh.. yeah adding other words I thought it wasn't relevant, I dind't thought this! Your are perfectly right! I didn't updated the script to last update, I'll do that and let you know!

Best regards as always

| enrico baravelli

2015-07-16 8:32 GMT+02:00 AndrewParkes notifications@github.com:

I think I know why the script doesnt work on your side. If you have changed your script to (comments.split("BOT").length) from (comments.split(" BOT ").length) with spaces it picks up all occurrences of BOT in any word for example the following words are found and counted as bot: bottom (4 times), bottomsubmenu, both(3 times). Thus finding 8 BOT comments in the comments section due to me not checking the actual comments correctly yet but rather the source of the entire comments page currently

— Reply to this email directly or view it on GitHub https://github.com/AndrewParkes/BlockAllSteamInvites/issues/2#issuecomment-121846246 .

AndrewParkes commented 9 years ago

Updated the script a little so that it should not count bottom, bottomsubmenu or both but it is still not perfect but should now allow you to add the extra words you want.

EnricoBara commented 9 years ago

Well thank you! Now the script works really better for bad comments!

Just a question, I want to auto-block the invites when page is reloaded, is it correct if I set to 1 this instructions?

var blockPrivateCheckBox=1;
var blockBannedCheckBox=1;
var blockNonSetupCheckBox=1;
var blocklvlCheckBoxValue=0;
var blocklvlCheckBox=1;
var blockbadcommentBox=1;

But I found that if the page is minimized from hours, chrome automatically suspend any plugins so I had to se in chrome://flags the funcion to don't force the plugins timeout. When you will indroduce the auto-block feature, I recommend you to perform a clear cache at every reload and to tell people to disable this chrome feature (I don't know if javascript can change this feature with tampermonkey)

Cheers

| enrico baravelli

2015-07-16 16:03 GMT+02:00 AndrewParkes notifications@github.com:

Updated the script a little so that it should not count bottom, bottomsubmenu or both but it is still not perfect but should now allow you to add the extra words you want.

— Reply to this email directly or view it on GitHub https://github.com/AndrewParkes/BlockAllSteamInvites/issues/2#issuecomment-121966517 .

EnricoBara commented 9 years ago

erm... the script can't remove a person (id: 76561198081459485) until I removed this strings

comments=comments.substring(comments.indexOf('<div class="commentthread_comment_author">')-1); comments=comments.substring(0 ,comments.indexOf('

')-1); and changed with comments=comments.substring(comments.indexOf('<div class="commentthread_comment_text">')-1); it's the div that contains the comments.. check it please

| enrico baravelli

2015-07-19 2:24 GMT+02:00 Enrico Baravelli enrico.baravelli@gmail.com:

Well thank you! Now the script works really better for bad comments!

Just a question, I want to auto-block the invites when page is reloaded, is it correct if I set to 1 this instructions?

var blockPrivateCheckBox=1;
var blockBannedCheckBox=1;
var blockNonSetupCheckBox=1;
var blocklvlCheckBoxValue=0;
var blocklvlCheckBox=1;
var blockbadcommentBox=1;

But I found that if the page is minimized from hours, chrome automatically suspend any plugins so I had to se in chrome://flags the funcion to don't force the plugins timeout. When you will indroduce the auto-block feature, I recommend you to perform a clear cache at every reload and to tell people to disable this chrome feature (I don't know if javascript can change this feature with tampermonkey)

Cheers

| enrico baravelli

2015-07-16 16:03 GMT+02:00 AndrewParkes notifications@github.com:

Updated the script a little so that it should not count bottom, bottomsubmenu or both but it is still not perfect but should now allow you to add the extra words you want.

— Reply to this email directly or view it on GitHub https://github.com/AndrewParkes/BlockAllSteamInvites/issues/2#issuecomment-121966517 .

AndrewParkes commented 9 years ago

No do not change the values. Just double click on the function(on the invites page) and it should be highlighted in blue. Once it is highlighted, on page refresh it will call that function(If page is refreshed within an hour).

Please redownload the script and see if it allows you to remove id: 76561198081459485. I have changed it slightly so that it should be able to find

and should search correctly to remove comments again
EnricoBara commented 9 years ago

Yes double click works until I close chrome. When I open chrome again I have to wait to receive a friend request and double click the buttons, because it doesn't keep saved my setting... Not comfortable... I successfully blocked this person with my change, so I'll wait for another one and I'll let you know. Hope my suggestions are helping and not bothering you!

Il domenica 19 luglio 2015, AndrewParkes notifications@github.com ha scritto:

No do not change the values. Just double click on the function(on the invites page) and it should be highlighted in blue. Once it is highlighted, on page refresh it will call that function(If page is refreshed within an hour).

Please redownload the script and see if it allows you to remove id: 76561198081459485. I have changed it slightly so that it should be able to find

and should search correctly to remove comments again

— Reply to this email directly or view it on GitHub https://github.com/AndrewParkes/BlockAllSteamInvites/issues/2#issuecomment-122632406 .

| enrico baravelli

AndrewParkes commented 9 years ago

I am using cookies for remembering if a function is double clicked. Thus if you close chrome and reopen the cookie should still exist.

My account was stolen and has been locked for another week so I cant test the cookies currently but when I can Ill let you know what to do.

AndrewParkes commented 9 years ago

In chrome goto: chrome://settings/ click show advanced settings under privacy click content settings check allow local data to be set click done

should keep the cookies on closing of chrome Hope it helps

EnricoBara commented 9 years ago

You mean the first (suggested) right? It's already set

| enrico baravelli

2015-07-19 16:38 GMT+02:00 AndrewParkes notifications@github.com:

In chrome goto: chrome://settings/ click show advanced settings under privacy click content settings check allow local data to be set click done

should keep the cookies on closing of chrome Hope it helps

— Reply to this email directly or view it on GitHub https://github.com/AndrewParkes/BlockAllSteamInvites/issues/2#issuecomment-122666619 .

EnricoBara commented 9 years ago

Even if I don't understand why my cookies aren't saved, this issue is done, I'll close it. Best regards

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.