AndrewPla / TOPdeskPS

PowerShell module to interact with the TOPdesk API
MIT License
30 stars 12 forks source link

Update Send-TdWebDAVFile.ps1 #105

Closed mabster closed 4 years ago

mabster commented 4 years ago

Send-TdWebDAVFile was not working with the latest TOPdesk version. I've swept over the function to make it work. Changed the content type to application/octet-stream per the TOPdesk knowledge article, and added some new target folders.

Requirements

Description of the Change

[ We must be able to understand the design of your change from this description. If we cannot get a good idea of what the code will be doing from the description here, the pull request may be closed at the maintainers' discretion. Keep in mind that the maintainer reviewing this PR may not be familiar with or have worked with the code here recently, so please walk us through the concepts. ]

Testing

[ Please describe the testing you have performed ]

Associated/Resolved Issues

[ Enter any applicable issues here ]

Note: By creating a pull request, you are expected to comply with this project's Code of Conduct.

AndrewPla commented 4 years ago

Thanks for all of your hard work. My apologies for the lack of activity lately. I have time scheduled in my calendar to work on this tomorrow.

On Mon, Aug 17, 2020 at 2:11 AM Matt Hamilton notifications@github.com wrote:

Send-TdWebDAVFile was not working with the latest TOPdesk version. I've swept over the function to make it work. Changed the content type to application/octet-stream per the TOPdesk knowledge article, and added some new target folders. Requirements

  • This template is required. Any request that does not include enough information may be closed at the maintainers' discretion.
  • Have you (put an X between the brackets on each line to confirm):
    • Written new test cases to ensure no regression bugs occur?
    • Ensured all test cases are now passing?
    • Ensured that PowerShell Script Analyser issues and warnings are completely resolved?
    • Updated any help or documentation that may be impacted by your changes?

Description of the Change

[ We must be able to understand the design of your change from this description. If we cannot get a good idea of what the code will be doing from the description here, the pull request may be closed at the maintainers' discretion. Keep in mind that the maintainer reviewing this PR may not be familiar with or have worked with the code here recently, so please walk us through the concepts. ] Testing

[ Please describe the testing you have performed ] Associated/Resolved Issues

[ Enter any applicable issues here ]

Note: By creating a pull request, you are expected to comply with this project's Code of Conduct.


You can view, comment on, or merge this pull request online at:

https://github.com/AndrewPla/TOPdeskPS/pull/105 Commit Summary

  • Update Send-TdWebDAVFile.ps1

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/AndrewPla/TOPdeskPS/pull/105, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHW57AHLMPLA66Q4S5L6U2LSBDCZNANCNFSM4QBJDCLQ .

mabster commented 4 years ago

Ok I think I've committed the required changes. See how you go!