search

AndrewRathbun / KAPE-EZToolsAncillaryUpdater

A script that updates KAPE (using Get-KAPEUpdate.ps1) as well as EZ Tools (within .\KAPE\Modules\bin) and the ancillary files that enhance the output of those tools
MIT License
53 stars 5 forks source link

Fix for Get-LatestEZToolsUpdater parameter check #15

Closed mpilking closed 2 years ago

mpilking commented 2 years ago

When running version 3.4 of the script, right at the beginning I get the error Get-LatestEZToolsUpdater : A positional parameter cannot be found that accepts argument '$null'.. This occurs whether or not I include the -DoNotUpdate parameter.

image

It seems to be related to this recent change: https://github.com/AndrewRathbun/KAPE-EZToolsAncillaryUpdater/commit/9c551c542f6daf5858a8b24fc2ea58a29a912049.

I tinkered around and changed the logic to check for -DoNotUpdate in the main part of the script instead of in the Get-LatestEZToolsUpdater function. I tested a bit and it seems to work as intended either with the -DoNotUpdate parameter or without it.

mpilking commented 2 years ago

In case you accept it and are ready to release it, don't forget to increment the version number. I didn't do that...

AndrewRathbun commented 2 years ago

In case you accept it and are ready to release it, don't forget to increment the version number. I didn't do that...

Looks good to me. I'll merge it first thing tomorrow so I can sign it, make a new release, etc. I'm on mobile now so not ideal. Thank you for the PR!

AndrewRathbun commented 2 years ago

@mpilking https://github.com/AndrewRathbun/KAPE-EZToolsAncillaryUpdater/releases/tag/3.5 is now live