AndrewSav
commented
2 months ago I removed the Find methods, from Analyser, but turned out performance improvement here were marginal, as it was just used in a few places where it did not affect performance much. Regarding the second bulled point I do not see a point spending time now on optimizing that since we removed the use of Find methods in the first place.
I see two potential performance improvements that need investigation:
Find*methods are particularly slow because they a) use regex and b) need to regex every single value to find the results. Every use of aFind*method can be examined to see if they can be replaced with faster alternativesFind*methods go over each value first, and the trim the result byparent. We can investigate if trimming by parent first is viable and if it could lead to better performance