[request] Prevent player status colour from overriding ship type colour

[JohanAR]

Great mod, really helps people like me who can't memorize the stats for every ship in the game!

Would it be possible to add an option to not colour ship type by status, i.e. pink and gold for self, and only use ship type colour when enabled?

[AndrewTaro]

I can't promise the addition since it's not a common request, but I'll consider it.

[JohanAR]

Would you accept a pull request if I try to implement it myself when I have time? And in that case, would it be acceptable with a switch for disabling gold and pink together, or would you prefer if they were individually configurable?

My reasoning is that I enable the ship type colours for improved glance value, and IMO the status colours interfere with that. Personally I don't find the tk status particularly useful to know while playing, and since I'm always in voice chat with my division members I don't need to look at the team panel to see if they're alive. At least for me, having the player names change colours is enough for this info.

[JohanAR]

I created a PR since I wanted to implement this for my self either way :)

Never done any WoWs modding before so I tried to guess how it's done by looking at the surrounding code. Toggling golden colour for self appears to be working, but I didn't get into a match with anyone having tk status so that isn't tested.

[AndrewTaro]

The merge still has to wait for a while.

The reason and main problem is, if I keep accepting all the suggestions without considering the popularity, the Mod Config will easily have 10000+ options for every single mod.

[JohanAR]

Aight, no worries. Do you know how popular class colour themes are, or if most people don't use one? Perhaps those who do haven't given much thought to combining a theme with status colours, and would be equally happy if the status colours always were disabled with a theme active :)

[AndrewTaro]

As far as I'm aware, many people prefer using the color themes. (but no one has raised the feedback about the status color so far. That's why I'm concerned about the popularity)

as you assumed, probably not many people have thought about it. I suppose some of the reasons are that

• There are few "pink" players nowadays
• The other team panels behave similarly.

I'm investigating how much this feature is wanted :)

[JohanAR]

Much appreciated! I don't want to give you any extra work, so let me know if there's anything I can help with.

I think it's the Aslain v2 theme I'm using, with yellow cruisers and pink-ish subs so they were quite close to the status colours. Perhaps there's less confusion with other themes

[JohanAR]

Hmm, could've sworn I posted these comparison screenshots a few days ago, but I must've forgot to click the submit button..

Current:

With change (if enabled):

[JohanAR]

Sorry for the spam, but have you noticed Github acting weird? When I wrote the post above I could see the comments on my PR but not the one containing the screenshots, which is why I posted them again here. When I checked yesterday it was there, but this entire issue was completely gone. The issue/feature request didn't show up regardless of filtering for open or closed.. And today all the comments on my PR are gone but now I can see this issue again.

[AndrewTaro]

Hmm, the screenshots/PR are visible to me. I'm not sure what's happening here

[JohanAR]

Lol no it's me being confused.. I forgot you have two repos with very similar names, and didn't realize that I was looking at different ones :D