search

Andrewnt219 / rent-near-me

https://rent-near-me.vercel.app/
1 stars 1 forks source link

Action fields should have placeholders #106

Closed Andrewnt219 closed 2 years ago

Andrewnt219 commented 3 years ago

The placeholders will prevent layout shifts on fetching the profile. I cannot reproduce in this video, but thr first time I logged in on my phone, it took a few seconds to show the data.

https://user-images.githubusercontent.com/52666982/141650715-5a963ff2-0a2f-4480-b3b9-9d144a1f0f79.mp4

vitokhangnguyen commented 3 years ago

Same issue as #105, no?

Andrewnt219 commented 3 years ago

Not really, #105 is a React problem. This is just a UX for loading state.

vitokhangnguyen commented 3 years ago

Let's fix this by just not showing the action fields until isProfileReady is true. Will do the same for /security