Andrewnt219 / rent-near-me

https://rent-near-me.vercel.app/
1 stars 1 forks source link

feat: sync states between layouts #112

Closed Andrewnt219 closed 2 years ago

Andrewnt219 commented 2 years ago

Description

Currently, if you enter something in the search bar and go to another page, the input will be reset. This is because Next.js doesn't recognize the nested layout as the same layout, so it doesn't do proper reconciliation.

Video shows fixed version.

https://www.awesomescreenshot.com/video/6012782?key=be957f01eb589a6bab38a61015fdd93c

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/andrewnt219/rent-near-me/ARVe6YdD27GBWYeUpED1EmRfc8Hj
✅ Preview: https://rent-near-me-git-sync-layout-states-andrewnt219.vercel.app

vitokhangnguyen commented 2 years ago

Good discover of the isssue 👏

vitokhangnguyen commented 2 years ago

Change base to main as well, we're doing house keeping, we only merge to dev when we have a milestone