Andrewnt219 / rent-near-me

https://rent-near-me.vercel.app/
1 stars 1 forks source link

Switch out ReachUI's MenuButton for RadixUI's DropDownMenu #120

Closed vitokhangnguyen closed 2 years ago

vitokhangnguyen commented 2 years ago

Changelog:

Note:

Currently, in development, react-dom would complain about Radix UI's mismatch id between client and server although IdProvider has wrapped around the entire app as this insturction from Radix suggests. This does not happens in production. The bug has been documented here by someone else.

Fortunately, a PR to resolve this has been merged 2 days ago. We could expect this issue to be fixed soon. A temporary solution to dismiss react-dom's complaining is to disable reactStrictMode. I'll create an urgent issue after this PR is merged to keep track of the fix (and docs) on Radix's side and update on our side asap. The update would also include re-enabling reactStrictMode.

Reflection:

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/andrewnt219/rent-near-me/JB4EJKwzkywtbGTitqpPuT8s8qfS
✅ Preview: https://rent-near-me-git-vitokhangnguyen-issue78menuv2-andrewnt219.vercel.app

Andrewnt219 commented 2 years ago

The grouping update is 💯.

image

vitokhangnguyen commented 2 years ago

The grouping update is 💯.

The only significant change that is visible to the user: I changed shadow to shadow-z8.

Cost: testng out 2 libraries, filing 1 open source issue, tracking 1 on-going open source PR, multiple code refactorings and sleeping schedule.

Worth it :)