Andrewnt219 / rent-near-me

https://rent-near-me.vercel.app/

1 stars 1 forks source link

Remove required `id` prop from form input elements #126

Closed vitokhangnguyen closed 2 years ago

vitokhangnguyen commented 2 years ago

Resolve #97

Changelog:

Use useId() hooks in form input elements to generate a deterministic id for the element (if one is not provided).
Switch out useId() in @radix/react-id with the one from react-aria (making the id looks more randomized).
Fix styling bug on MenuItem that displays hovered item the same as focused

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/andrewnt219/rent-near-me/7m4gxgh7hoNdC77acRzpjG6YfL7m
✅ Preview: https://rent-near-me-git-vitokhangnguyen-issue97-andrewnt219.vercel.app

Andrewnt219 commented 2 years ago

making the id looks more randomized

really?

vitokhangnguyen commented 2 years ago

making the id looks more randomized

really?

actaully, I'm gonna revert back to @radix-ui/react-id before merge. The package is like 45 time lighter in size. Or should we just leave it to tree-shaking?

Edit: Nah, base on the export analysis here, it's still heavier after tree-shaking.