Andrews54757 / FastStream

Stream videos without buffering in the browser. An extension that gives you a better, accessible video player designed for your needs.
https://faststream.online/
Other
443 stars 30 forks source link

Add id = "player" to iframe #167

Closed ChromiaCat closed 4 months ago

ChromiaCat commented 4 months ago

I'm using an extension called "Comments Sidebar for Youtube" and FastStream is broken whenever that extension is active. Adding id = "player" makes the player snap to the place it's supposed to, although I wish I could figure out how to make FastStream properly resize when the split bar is moved, at least going to fullscreen and back does the job at resizing it.

Andrews54757 commented 4 months ago

Implemented with slight changes. The player ID is only set for youtube videos.

ChromiaCat commented 4 months ago

Could you restore this please? It's not causing #175 in my testing with & without the id set.

Andrews54757 commented 4 months ago

It caused the player to be hidden in my own testing when in theatre mode. image

Andrews54757 commented 4 months ago

I've reimplemented it in a different way in 1.3.13. I hope it works.