Andrews54757 / FastStream

Stream videos without buffering in the browser. An extension that gives you a better, accessible video player designed for your needs.
https://faststream.online/
Other
443 stars 30 forks source link

[BUG] Some videos don't load completely on Brave #190

Closed Vitor-ui closed 4 months ago

Vitor-ui commented 4 months ago

Describe the bug Even with the extension configured to not limit video loading, some videos end up limiting it, some by 4.5%, others by 12%.

Version FastStream 1.3.14

Platform Brave

Steps to Reproduce Start a YouTube video with the extension unlimited, and wait to see if it's fully loaded, this happens with some videos, I can't tell if it's the original format of the video or a general bug

image

Andrews54757 commented 4 months ago

Can you provide an example video?

Vitor-ui commented 4 months ago

https://github.com/user-attachments/assets/d9c9c7d1-74d3-41c4-ae76-b9f4e8721b79

does this work?

Andrews54757 commented 4 months ago

No I mean provide a URL to an example youtube video where the issue happens so I can replicate the issue on my computer.

Vitor-ui commented 4 months ago

https://www.youtube.com/watch?v=nylsQV-xMZM

Andrews54757 commented 4 months ago

Are you perhaps using private mode or incognito?

Vitor-ui commented 4 months ago

I'm using normal mode, other than the incognito tab

Andrews54757 commented 4 months ago

It is possible that the size of the video exceeds the storage capacity of your browser. In that case it will not buffer the whole video even if you set no limit in FastStream settings.

Vitor-ui commented 4 months ago

This doesn't make sense, there's a 3 hour video that loads completely even in 4k

Vitor-ui commented 4 months ago

Do you know how to increase the limit? If I put the video in 1080p it loads completely normally, but there are some that don't load completely

Andrews54757 commented 4 months ago

Right click the faststream player, click inspect element, then click "console"

Paste this into the console, and press enter.

console.log(fastStream.hasDownloadSpace, fastStream.shouldDownloadAll(), fastStream.options.downloadAll, fastStream.storageAvailable)

Tell me what the results are

Vitor-ui commented 4 months ago

image

Andrews54757 commented 4 months ago

What about fastStream.options.maxVideoSize?

Try pasting that into the console and tell me the results. It should be equal to -1

Vitor-ui commented 4 months ago

image

Andrews54757 commented 4 months ago

I think your available storage is too small. It is only 2GB which is easily exceeded by a 20 min video in 1440p. My available storage is 450 GB and it loads completely for me. Try using 1080p instead.

The amount of available storage you have is controlled by your browser depending on factors such as your available disk space and whether you are using private browsing. It is not something faststream can control directly.

Vitor-ui commented 4 months ago

I have 340GB free, and it's still an SSD, so it just doesn't make sense

Andrews54757 commented 4 months ago

The browser you are using may impose additional restrictions

Andrews54757 commented 4 months ago

Try using regular chrome and see if you get the same results

Vitor-ui commented 4 months ago

I tested with Chrome and Brave, Brave was limiting at 11.5% and Chrome loaded normally, do you have any idea how to remove this storage limitation?

Andrews54757 commented 4 months ago

Unfortunately I do not. You will have to ask the Brave developers.