[BUG] Scrolling the volume icon is reversed

Andrews54757 / FastStream

Stream videos without buffering in the browser. An extension that gives you a better, accessible video player designed for your needs.

https://faststream.online/

Other

434 stars 30 forks source link

[BUG] Scrolling the volume icon is reversed #198

Closed Araxeus closed 3 months ago

Araxeus commented 3 months ago

Describe the bug When I scroll with my mousewheel over the volume icon/bar - the direction is reversed

Scrolling up should raise the volume up
Scrolling down should lower the volume down

(Currently scrolling up lowers the volume and scrolling down raise the volume)

Version 1.3.17

Platform Chrome

https://github.com/Andrews54757/FastStream/blob/ce2d02a9a4893c87dad7584ec49eb876885e686f/chrome/player/ui/VolumeControls.mjs#L31-L38

Araxeus commented 3 months ago

@Andrews54757 hi could you explain your commit? deltaY shouldn't be different on macOS?

Andrews54757 commented 3 months ago

MacOS trackpads have an inverted scrolling gesture. swiping up will move the page down.

Araxeus commented 3 months ago

Interesting, I own a browser extension that do scrolling similar to this, and it has hundreds of MacOS users but no one ever complained about this

Andrews54757 commented 3 months ago

You're the first person to bring this issue up even though thousands of people, many without Macs, have used FastStream. Congratulations on being observant!

Araxeus commented 3 months ago

haha yeah I guess most people don't bother filling github issues