search

Andrewsville / PHP-Token-Reflection

Library emulating the PHP internal reflection using just the tokenized source code
http://andrewsville.github.com/PHP-Token-Reflection/
Other
190 stars 44 forks source link

Unit tests fail massively #73

Open kdambekalns opened 9 years ago

kdambekalns commented 9 years ago

The current state of the project is that a lot of tests fail, even on PHP 5.3 and 5.4, as is clearly visible on TravisCI. This is really a bad situation, since it more or less makes it impossible to work on the codebase - you would need a "green bar" before you can do that safely.

I started to look at the tests, but since some tests fail due to functionality added in recent PHP versions, it might make sense to define the way forward first… Would it be an option to drop support for PHP 5.3 and 5.4, and have newer versions support PHP 5.5 and up? This could safely be done by bumping to version 2.0 of the library. For the current state, that would still mean fixing things, so that the tests run again on PHP 5.3 and 5.4, of course.

Any pointers on how to approach this? I would invest some (more) time into this, but would welcome some introduction to the architecture (of the tests), to speed things up.

jankal commented 7 years ago

As far as I know, this repo is abandoned. There won't be any updates anymore. Even if I'll be trying to keep this up when I have some spare time from ApiGen/ApiGen. But there we'll probably use goaop/parser-reflection.