Andrewthe13th / Inventory_Kamera

Scans Genshin Impact characters, artifacts, and weapons from the game window into a JSON file.
MIT License
691 stars 115 forks source link

Scanner unable to validate (almost) all of my artifacts #114

Closed Paws26 closed 2 years ago

Paws26 commented 2 years ago

I was using 1280x720 Windowed as suggested and the scanner was only able to validate 15 out of 328 artifacts. I've also tried different Scan Delay settings with no difference.

image

Andrewthe13th commented 2 years ago

Have you tried restarting genshin at the same resolution? There are known issues with resizing the window that messes up the UI a bit.

Paws26 commented 2 years ago

I have done that just now, closed and opened Genshin at 1280x720 but It had the same result. It's weird that it only works for a very few artifacts.

Edit: The 1.0V of the Scanner seems to work and scan every artifact correctly, the 1.1V fails to do so for me. Edit 2: 1.0V Scanner scans the artifacts correctly but does not output any GOOD/json file on completion (even with an available and determined folder selected), instead it just closes itself.

Cupcak3 commented 2 years ago

You're right that it is strange that it can scan some artifacts but not nearly a significant percent. I will have to write some better error output to be able to tell exactly what's causing the validation to fail.

Ame55 commented 2 years ago

Hi i have the same problem and on Genshin Optimizer i have only artefact with only FLAT sub stat, none of them have a percent stat. I don't know if it help.

Edit: I used 1280x720 Windowed image

Cupcak3 commented 2 years ago

@Ame55 this seems to be a different issue. Please open a new issue. Additionally if you can provide a screenshot of at least one of the artifacts in-game that should have % substats and how it appears in GO it would be much appreciated.

Dranixx commented 2 years ago

I do think it's the same issue, I also get Unable to validate information for artifact #329 for every artifacts that have a % substats. As you can see here only artifacts with FLAT subs get scanned. image

During the scan it didn't show anything in the output artifacts windows, so don't know what causing the validation to fail.

Ame55 commented 2 years ago

Sorry, I misspoke, I meant that like Paws26, and now Dranixx, only a small part of my artifacts were scanned. The Error Unable to validate information for artifact #

image

And that after transferring the data to GO, I noticed that the scanned artifacts only had flat substat.

image

I apologize for not having correctly explained the problem previously.

reloxx13 commented 2 years ago

same here, worked fine with 1.0. since 1.1 substats are missing

tolukolvi commented 2 years ago

I managed to get all scanned after pulling the development version from git, building it with Visual Studio and then replacing v1.1 version files with the newly built files. However, I can't import anything to seelie.me even thou the json-file has all the data in it.

Cupcak3 commented 2 years ago

Hi there, this issue is hopefully resolved in the v1.1.1 prerelease. If it has been, please let us know so we can close this issue.

@tolukolvi : There are two places you can import to seelie.me, one in the Inventory panel and one in the Settings panel. I believe you need to use the Inventory panel's import button and use the GOOD option.

Ame55 commented 2 years ago

@Cupcak3 I just tested a new version, everything seems to be working normally, if I find something I will let you know.

Thank you for everything.

Cupcak3 commented 2 years ago

I am going to close this issue as one user has reported it being fixed and the other users in the thread have not replied in a while. Please feel free to reopen this issue or to open a new issue should any problems come up.