search

Andrewthe13th / Inventory_Kamera

Scans Genshin Impact characters, artifacts, and weapons from the game window into a JSON file.
MIT License
691 stars 115 forks source link

Artifacts scan gets wrong results #134

Closed burekitas closed 2 years ago

burekitas commented 2 years ago

hey, something goes wrong with artifact scanning. some artifacts just got completely wrong resaults. in this picture for instance - my zhongli have a TOTM flower and WT goblet. also, gambler's and berserker cant be 5*. and I got the flower string from the jason - it's missing a substat. {"setKey":"Gambler","slotKey":"flower","rarity":5,"mainStatKey":"hp","level":20,"substats":[{"key":null,"value":0.0},{"key":"hp","value":4.1},{"key":"def","value":19.0},{"key":"enerRech","value":25.9}],"location":"Zhongli","lock":false,"SubStatsCount":4,"Id":8}

image

from a brief scan of the rest in genshin optimizer I think that's all it got wrong but I'm not a 100% sure

ps - this tools doesn't read mora?

thanks

Cupcak3 commented 2 years ago

Thanks for the report. Unfortunately this is a tricky thing to assess and catch problems at run time. Text recognition of the sub-stats and artifact set name are the trickiest because of the green text that the artifact name uses. We're working on ways to improve scanning accurate artifact sets, which should also improve the accuracy of missing sub stats.

The tool also doesn't scan mora yet. We will add that in.

Cupcak3 commented 2 years ago

Hi there, this issue is hopefully resolved in the v1.1.1 prerelease. If it has been, please let us know so we can close this issue.

The scanner also now scans mora when scanning materials.

burekitas commented 2 years ago

I believe 1.2 solved this problem so I'll close it. but it did fail to parse the mora amount