search

Andrewthe13th / Inventory_Kamera

Scans Genshin Impact characters, artifacts, and weapons from the game window into a JSON file.
MIT License
691 stars 115 forks source link

v1.2 skipping 6th column #173

Closed Cunningcory closed 2 years ago

Cunningcory commented 2 years ago

I've tried various 16:9 and 16:10 resolutions.

Items are in rows of 7. Sometimes, but not all the time, the 6th item of every row is skipped. I first noticed it when scanning artifacts. I restarted and then it seemed to work fine until it got to materials and then skipped the 6th item for half of the materials scan before correcting and hitting all 7 again. I have it set to a 50ms delay. I'm on an ultrawide monitor but I have the resolution set correctly for the scan and restarted Genshin after setting the resolution.

Andrewthe13th commented 2 years ago

Yea I have noticed this as well sometimes. Thanks for testing and telling me your findings. I think I will need to fix an issue in the programming.

Cupcak3 commented 2 years ago

Can you try scanning the same inventory tabs after moving to different places in the world?

The algorithm that the scanner uses to find rows and columns of items can sometimes be sensitive to the colors of the heavily blurred background. If the colors of the background blur with the dominant color corresponding to the rarity of the item then that's when I found this sort of issue happened in testing.

Cunningcory commented 2 years ago

Can you try scanning the same inventory tabs after moving to different places in the world?

The algorithm that the scanner uses to find rows and columns of items can sometimes be sensitive to the colors of the heavily blurred background. If the colors of the background blur with the dominant color corresponding to the rarity of the item then that's when I found this sort of issue happened in testing.

Nothing I could do would get it to scan all the artifacts properly. It consistently would skip one artifact of each row, despite changing backgrounds and times of day. I did notice changing the time of the day could get it to skip an entire section (daytime made the scanner skip weapons completely) and at one point made it worse where it was skipping two artifacts in each row. Toggling to just scan artifacts also didn't work. I could not find any combination that would scan artifacts properly. It always would skip at least one in every row.

Cunningcory commented 2 years ago

I switched back from a 16:10 resolution to a 16:9 resolution and was able to get it to not skip as much. At 0ms it seems I missed 8 artifacts and at 100ms delay I missed 5.

Cupcak3 commented 2 years ago

Please check out the v1.2.2 release. It improves on finding inventory items as well as an update for the game's v2.5 inventory UI update.