Andrewthe13th / Inventory_Kamera

Scans Genshin Impact characters, artifacts, and weapons from the game window into a JSON file.
MIT License
691 stars 115 forks source link

When importing artifacts to GO, there are some invalid artifacts #231

Closed Cocolatte0403 closed 2 years ago

Cocolatte0403 commented 2 years ago

image I used Inventory Kamera to scan my artifacts for Genshin Optimiser but for some reason Genshin Optimiser said that there were invalid artifacts. I looked through the json file and for some reason Inventory Kamera scanned some artifacts under the "Tea" artifact set. Also, when I imported the json file to GO, some of my artifacts became 5* Gambler artifacts too.

Cupcak3 commented 2 years ago

Looks like there was some weird data that shouldn't be where we're collecting our artifact set information from. It should be a simple filtering fix to make sure something like this doesn't happen in the future.

In the meantime, in the artifacts.json file under inventorylists try deleting the items below (basically delete everything that isn't a real artifact set) and let me know if the scan gets the artifact sets right. They're likely at the very bottom of the file, or very top if you used the auto updater to create a new file. image

Cocolatte0403 commented 2 years ago

I did as you told and there are no more artifacts saved under weird names. However I think the scanner has been saving my Ocean Hued Clam artifacts under the scholar artifact set...

image

Also, I'm not sure if this is related but some of my artifacts have been removed from GO after I uploaded the latest json file that I scanned which presumably has the same artifacts as the previous json file I scanned today as I didn't do anything to my artifacts at all.

image

Jolopundrio commented 2 years ago

Same problem. 35 artifacts from GladiatorsFinale were scanned as Tea. If I delete the items in artifacs.json as suggested, there is no error but the artifacts affected vanished. I have also lost at least another artifact from BlizzardStrayer I detected it becasuse it is equipped for Ayaka and now Ayaka has only 4 artfifacts, not five. In this case is not renamed, it vanished. imagen