Andrewthe13th / Inventory_Kamera

Scans Genshin Impact characters, artifacts, and weapons from the game window into a JSON file.
MIT License
691 stars 115 forks source link

[BUG] ATK Sands results into invalid in Genshin Optimizier #290

Closed jamespmnd closed 2 years ago

jamespmnd commented 2 years ago

ATK % Sands is read as invalid in Genshin Optimizer. Account was scanned without issues from the log as well. Upon upload in Genshin optimizer, not a single ATK % artifact showed up. The rest of the artifacts were fine.

Info about your device

Additional Notes / Remarks

Add any other context about the problem and log files/report here.
If you managed to find any related or similar issue, please paste a link here.

Checklist before sending issue

Here's everything you should try before sending this issue. Make sure that you have completed it accordingly.

Instruction: Check the tickbox by replacing [ ] with [x] (in editor) or tick it after leaving the Text Editor:

Additional checklist for Scanning issues

Instruction: If your issue does not relate to scanning issue, feel free to delete any unrelated checklist.

  • [ X] I tried setting the delay to maximum and still experiencing issues.
Cupcak3 commented 2 years ago

Please check to see if those goblets missing goblets are in the export file at all or upload it here. If those artifacts are not in the file at all, then that's one problem. If they are in the file, please double check that the values reflect the actual in-game artifact. There's no way to know what the problem is without an upload.

AneJlbcuH4uk commented 2 years ago

Have same issue today. The problem is that scanner wrote wrong mainstat for sands circlets and goblets (def not def, atk not atk , hp not hp_) into json file. Changing this stats manualy fixed the issue at least for me.

jamespmnd commented 2 years ago

Have same issue today. The problem is that scanner wrote wrong mainstat for sands circlets and goblets (def not def, atk not atk , hp not hp_) into json file. Changing this stats manualy fixed the issue at least for me.

Sorry a bit of a newbie here, how did you change it manually? Which program did you use? In connection to this, seeing as there might be hundreds of atk entries in the file, how did you sort out which ones to replace?

AneJlbcuH4uk commented 2 years ago

Have same issue today. The problem is that scanner wrote wrong mainstat for sands circlets and goblets (def not def, atk not atk , hp not hp_) into json file. Changing this stats manualy fixed the issue at least for me.

Sorry a bit of a newbie here, how did you change it manually? Which program did you use? In connection to this, seeing as there might be hundreds of atk entries in the file, how did you sort out which ones to replace?

actualy i dont have much arts . Had to edit only 10-ish. You can edit your genshinData file in any text editor but it will be uncomfortable. I used sublime text. For sublime just open in sublime press CTRL+F enter "setkey" press find all then press left arrow on keyboard twice and press Enter. That will move each of your artifacts to a new line. After that you can watch on Genshin optimizer website which of the arts is invalid and search for them in your file just edit "mainStatKey" in arts that invalid.

Cupcak3 commented 2 years ago

This should be fixed in recent versions.