Andrewthe13th / Inventory_Kamera

Scans Genshin Impact characters, artifacts, and weapons from the game window into a JSON file.
MIT License
691 stars 115 forks source link

[BUG] Weapon scanning stops after scrolling to second page at 1680x1050 #295

Closed doxxx closed 2 years ago

doxxx commented 2 years ago

What happed? What is seems to be a bug?

Weapon scanning scans the first page, scrolls to second page and then stops without scanning any more weapons even though they meet the rarity and level criteria.

How to reproduce this issue

  1. Ensure that you have enough weapons to cover two pages at a resolution with an aspect ratio of 1.6, e.g. 1920x1200 or 1680x1050, etc.
  2. Select Weapons in IK and set minimum weapon rarity and level such that weapons on page 2 would be scanned.
  3. Start scanning.

What seems to cause this issue?

There's an error message in the log:

Insufficient items found in weapon inventory
   at InventoryKamera.WeaponScraper.ProcessScreenshot(Bitmap screenshot)
   at InventoryKamera.WeaponScraper.GetPageOfItems(Int32 page)
   at InventoryKamera.WeaponScraper.ScanWeapons(Int32 count)
   at InventoryKamera.InventoryKamera.GatherData()

Expected behavior

All weapons are scanned based on filters.

Info about your device

Additional Notes / Remarks

If I switch the resolution to 1920x1080, the problem no longer occurs. Delay was set to "Slower".

Checklist before sending issue

Instruction: Check the tickbox by replacing [ ] with [x] (in editor) or tick it after leaving the Text Editor:

Additional checklist for Scanning issues

Cupcak3 commented 2 years ago

This kind of error will generate screenshots under logging\weapons and logging\artifacts respectively. Please upload those.

doxxx commented 2 years ago

For a weapon scan which fails, it only produced one screenshot in the logging\weapons folder. I've attached that and the corresponding log files.

InventoryKamera.debug.log InventoryKamera.log WeaponInventory

backerman commented 2 years ago

Same deal on my machine (XPS 17 9700, 3840x2400 display, Genshin Impact 2.7 running in windowed mode at 2560x1600) with master 42d69c457f7dd07e4bcd6a111b7bb46e54e9e351. A second atttempt worked for weapons, still partially succeeded for artifacts (86 of 93 scanned), failed for materials and character development items.

Retrying artifacts alone on slower works (but double-scans the first page and fails on one Instructor's Feather for some reason.)

Cupcak3 commented 2 years ago

V1.2.7 should have some fixes aimed towards insufficient items in inventory. Let me know if that version fixes the issue

Cupcak3 commented 2 years ago

I am closing this issue for no response. Feel free to reopen this issue.