[BUG] Artifact scan stops upon reaching high level, lower stared artifact.

seeLelouch commented 2 years ago

What happed? What is seems to be a bug?

GenshinImpact_iLHi5aCqUe

If you look at the picture, the scanner will stop after reaching the 3-star sands under the settings "Minimum artifact rarity 5 and minimum artifact level 4".

Scanner should continue scanning a few of the artifacts that come after.

How to reproduce this issue

Level a 3? star artifact to above desired 5 star level and lock? it

Expected behavior

Scanner should continue scanning a few of the artifacts that come after.

Info about your device

Device Operating System : Win 10
Genshin Impact Version : 1.7
Inventory Kamera Version : 1.2.6
Screen resolution(s) affected : 1440x900, others not tested

Checklist before sending issue

Instruction: Check the tickbox by replacing [ ] with [x] (in editor) or tick it after leaving the Text Editor:

[ x] I have checked Issue page and there is none that is related to mine.
[ x] I am using the latest version of Inventory Kamera or/and have clicked Update Lookup Tables to update the database.
[ x] I have filled in "Info about your device" section.
[ x] I have correctly set my character and inventory keys in Inventory Kamera
[ x] I do NOT have any image filtering softwares enabled for Genshin (HDR, Image Sharpening, etc.)

Additional checklist for Scanning issues

[ x] I tried setting the delay to maximum and still experiencing issues.
[x ] I have attached media and log files that Inventory Kamera generates. InventoryKamera.debug.log

Cupcak3 commented 2 years ago

Thanks for bringing this to my attention. I see the problem and figure out a fix.

Cupcak3 commented 2 years ago

I believe V1.2.7 should fix this issue.

seeLelouch commented 2 years ago

I believe V1.2.7 should fix this issue.

Issue persistent in 1.2.7

seeLelouch commented 2 years ago

https://github.com/Andrewthe13th/Inventory_Kamera/blob/9dcceffe08f9e00d37b20dcc56fa234094436698/InventoryKamera/scraping/ArtifactScraper.cs#L472

The problem lies in the algorithm and I am guessing it would have to be changed quite a bit to fix this.

Scanning until last desired level of artifact of wanted rarity and disposing of artifacts with lower rarity than wanted?

Cupcak3 commented 2 years ago

Sorry for missing this with the V1.3.0 release. I'll have it fixed in the next version

Andrewthe13th / Inventory_Kamera