Andrewthe13th / Inventory_Kamera

Scans Genshin Impact characters, artifacts, and weapons from the game window into a JSON file.
MIT License
686 stars 115 forks source link

[BUG] Traveler recognized as existing character if name is partially or fully matching #327

Open Noobyguy775 opened 2 years ago

Noobyguy775 commented 2 years ago

NOTE Please describe on each question as much as you can. This will speeds up our bug fixing process.

What happed? What is seems to be a bug?

If the traveler's name contains a name of character already in the game, it will label the traveler that character (ex. Username ingame: eula_simp -> would make the scanner think the traveler is eula.

How to reproduce this issue

Name yourself a character, run scanner, code says the traveler is that character.

What seems to cause this issue?

Scanner reads traveler name as the character mentioned. (ex. if my name was Fishcl, then the scanner would say i have 2 fishcls.

Expected behavior

Info about your device

Additional Notes / Remarks

Checklist before sending issue

Instruction: Check the tickbox by replacing [ ] with [x] (in editor) or tick it after leaving the Text Editor:

Cupcak3 commented 2 years ago

This.... is going to be a problem lol I can maybe fix this if your username contains an existing character's name. But figuring out a fix for when your username completely matches an existing character is going to be much more work and may not be feasible.

MayumiMi commented 2 years ago

This can happen to a name similar to a playable character name too. My name is "Mayumi" and it recognize it as Sayu

Jeinara commented 1 year ago

Similar problem for Wanderer(custom name is an understandable pain). Mine is "Сенко" and it recognize it as "Cyno"

Cupcak3 commented 1 year ago

Scanning in other languages is not supported. This is a limitation of the program's state as of now since the scanner only recognizes the English alphabet. Unfortunately there are no plans in motion for language support, but obviously it would be great to have.