Andrewthe13th / Inventory_Kamera

Scans Genshin Impact characters, artifacts, and weapons from the game window into a JSON file.
MIT License
691 stars 115 forks source link

HDR display breaks scanner #385

Closed derekxwu closed 8 months ago

derekxwu commented 2 years ago

Current Behavior

HDR washes out SDR screenshots, breaking Inventory Kamera's OCR. Windows 11 pushes HDR/Auto HDR heavily, so it's becoming easier to encounter this.

It seems this already a known issue, but doesn't fail cleanly. Instead, the scanner behaves erratically - 2* weapons scan as Rust with negative refines, rows of artifacts are skipped, etc. HDR being a source of issues is also not mentioned in the software or README - just the checklist for bug reports.

Proposed fix: Scanner should detect HDR and promptly fail with a user-friendly message. There may be a Windows 11 API to check if auto HDR is enabled, or the Paimon menu could be used as a litmus test. 1663528690

Expected Behavior

The scanner stops scanning

Reproducing a Behavior

Run Genshin in HDR via Windows 11 Auto HDR.

Device OS

Windows 11

Genshin Impact Version

3.0

Inventory Kamera Version

1.3

Screen resolution, screen mode, and UI scale

1080p, 720p, 900p

Additional notes and remarks

No response

Evidence

No response

Preflight Checklist

Cupcak3 commented 8 months ago

Duplicate of #164