Andrewthe13th / Inventory_Kamera

Scans Genshin Impact characters, artifacts, and weapons from the game window into a JSON file.
MIT License
685 stars 114 forks source link

[BUG] Ultrawide Resolution Fix #40

Open mineminemine opened 2 years ago

mineminemine commented 2 years ago

So this is in regards to those that have their scanner crashing on them while scanning. I've been trying to debug this problem for awhile now and seemed to have finally found the culprit behind the crashing. Note: this likely only applies to those that have monitors that are not in the 16;9 ratio, like my ultrawide monitor that is in 21:9. Note2: I use the term 'compressed' and 'uncompressed' here, but it's likely not the right term, hopefully you get the idea..

The problem:

The fix:

Example images below:

Wrong UI for scanning, the UI is compressed wrong wrong1

Correct UI for scanning, the UI is not compressed correct correct1

Andrewthe13th commented 2 years ago

Wow. You actually figured out the resizing issue. It for sure affects my screen since I use my ultrawide. I just never noticed it too much since i don't really play the game too much in full screen. I will update the start up rules to mention this. Thanks for your help with the troubling issue.

Fradgaxd commented 2 years ago

I still have a issue with it crashing :) I got only 1 24 inch 16:9 monitor. I set the game to 1280x720 windowed exit the game, launch the tool start the game (now in windowed 1280x720) but it wont scan at all. Same issue on both Windows 11 and Windows 10 to so its not the OS atleast

Andrewthe13th commented 2 years ago

I should try my scanner on my spare screen. I think 21 inch 720p. Could be dpi issue or other issue I can't see on my ultra wide.

CamiloZamora21 commented 2 years ago

I play on a 27'' 1080p monitor (idk if frequency matters but 144hz) and it also keeps crashing even after trying this t.t. Windows 10 also. If that's relevant, AMD GPU.

mineminemine commented 2 years ago

@Andrewthe13th Maybe add a setting screen that allows the users to see whether the snapshots taken by the scanner is correct on their side? Or add an advanced settings that allow the users to edit the position offsets would help?

ArnoldsK commented 2 years ago

This worked! Also had to open it via the launcher, not steam. The borderless mode made it crash, too.

Zerawan2042 commented 2 years ago

Works for me

Cupcak3 commented 2 years ago

Wow. You actually figured out the resizing issue. It for sure affects my screen since I use my ultrawide. I just never noticed it too much since i don't really play the game too much in full screen. I will update the start up rules to mention this. Thanks for your help with the troubling issue.

I'm working on a solution that should address the problem with a compressed UI. It should work for all 16:9 resolutions, compressed UI or not, but I don't have any ultrawide resolutions in Genshin so there's not much I can do to induce the compressed UI.

aingerusanchez commented 2 years ago

I have a 34" ultrawide monitor (21:9) and the instructions worked for me (in my case 1920x1200 windowed) but only after closing and relaunching the game.

Vadorequest commented 3 weeks ago

I ran into this, too.

I was playing on my TV, but even after disconnecting it, using 1920*1080, 1200*720, and restarting the game every time, it always crashes after clicking on 4-6 weapons.


Edit: Using https://github.com/akrios-d/AkashaScanner helped me fix this issue.