Andrewthe13th / Inventory_Kamera

Scans Genshin Impact characters, artifacts, and weapons from the game window into a JSON file.
MIT License
678 stars 113 forks source link

3.3 patch the scanner stopped scanning after first artifact. #404

Closed nammerduong closed 1 year ago

nammerduong commented 1 year ago

Current Behavior

I don't know if it's the new patch but this app wont scan more than 1 artifact anymore. I am using the new 1.3.3 version but tried to scan on older versions too and still failed. I should mention that when the scan finishes, for some reason a new folder named "Inventory_KameraV1.3.0" gets made on my desktop and that's where the export folder goes into. I also tried to change the game's resolution but the scanner still wont function anymore.

Expected Behavior

The scanner continues to scan

Reproducing a Behavior

be in paimon escape menu and press scan genshin. It wont scan more than 1 artifact.

Device OS

Windows 10

Genshin Impact Version

3.3

Inventory Kamera Version

1.3.3

Screen resolution, screen mode, and UI scale

1600*900

Additional notes and remarks

No response

Evidence

No response

Preflight Checklist

Cupcak3 commented 1 year ago

It would appear that HoYo broke something with their inventory in the new update that impacts scanning. The item cards no longer retain the correct scrolled positions when changing resolutions. In previous Genshin versions this did not happen and the scroll was always set automatically to the top. Since the scanner assumed this to always be the case, it will break if the item description is not scrolled to the top.

Ensuring the item region is scrolled to the top should be enough of a workaround for now.

I may get out an update to safeguard against tomorrow or something, but I consider this a bug with the game and should be addressed there.

Here's a visualization of what I mean: image image These are full monitor captures of 1600x900 -> 1920x1080 resolution changes. The only actions I take are to exit the inventory, change the resolution, and enter the inventory again. As you can see the item card is not scrolled to the top like it is in the first image.

teddster2002 commented 1 year ago

ive ran into the same problem but i keep getting the 'Unable to locate artifact count.' error the version im using is the most recent

Cupcak3 commented 1 year ago

A fix was implemented for this issue a while back. Hoyo has also fixed the root cause. The fix is no longer necessary but scanning still appears to work so I am closing this issue as fixed.