Andrewthe13th / Inventory_Kamera

Scans Genshin Impact characters, artifacts, and weapons from the game window into a JSON file.
MIT License
691 stars 115 forks source link

Scanning artifacts function alternate between missing rows and repeating rows for certain resolutions #460

Closed ecpgieicg closed 1 year ago

ecpgieicg commented 1 year ago

Current Behavior

In resolution 2560x1440 (full screen on my PC) and 1920x1440, I find the tool frequently misses rows and repeat rows when scanning artifacts. This happens when the artifact UI scrolls with the 1st row of the artifact grid being imperfectly aligned with the box that displays artifacts. When the misalignment is big enough, Inventory Kamera appears to select which row to continue based on how much the 1st row is cut off.

This method is however unreliable and result in the scan alternating between missing a row, being correct on a row, and repeating a row. (Never strictly alternative between these 3. Only loosely alternating.)

I think the tool needs to be able to identify the highlighted artifact as that labels the previously selected and scanned artifact. Since the scrolling UI does not change the previous highlight, that will always identify the correct row to scan next.

Expected Behavior

The scanner to not miss row or items

Reproducing a Behavior

Use 2560x1440 and 1920x1440 in Genshin graphics setting.

Start scanning artifacts.

Pay particular attention to the alignment of artifact grid with the display box.

For any resolution where misalignment occurs, there should be missing rows and repeated rows.

Device OS

Windows 10

Genshin Impact Version

3.7

Inventory Kamera Version

1.3.8

Screen resolution, screen mode, and UI scale

2560x1440, 1920x1440

Additional notes and remarks

No response

Evidence

Here is the result from one of the scans I visually noticed missing/repeated rows.

I don't have a tool myself to parse the json file and don't really have an easy way to detect duplicates.

It is easy to verify missing artifacts, however.

This is part of my current inventory in the same state. Note the number of level 1 head pieces from the Emblem set is 11. Meanwhile, in the scanned result, there are only 3 level 1 head pieces from Emblem set.

Preflight Checklist

Cupcak3 commented 1 year ago

An issue already exists describing this issue. I am closing this as a duplicate.