Andrewthe13th / Inventory_Kamera

Scans Genshin Impact characters, artifacts, and weapons from the game window into a JSON file.
MIT License
697 stars 121 forks source link

artifact scanner is broken #483

Closed Spongman closed 9 months ago

Spongman commented 1 year ago

Current Behavior

1920x1200

it only finds one artifact image

image

Expected Behavior

The scanner continues to scan

Reproducing a Behavior

scan artifacts

Device OS

Windows 10

Genshin Impact Version

latest? instructions on how to find this would go a long way here ...

Inventory Kamera Version

master

Screen resolution, screen mode, and UI scale

1920x1200

Additional notes and remarks

No response

Evidence

No response

Preflight Checklist

Spongman commented 1 year ago

image

Spongman commented 1 year ago

switching the game to fullscreen 1920x1080 results in "Unable to locate Artifacts item count.". switching the game to windowed 1920x1080 results in

Object reference not set to an instance of an object.
   at InventoryKamera.InventoryScraper.GetPageOfItems(Int32 pageNum, Boolean acceptLess) in C:\play\Inventory_Kamera\InventoryKamera\scraping\InventoryScraper.cs:line 467
   at InventoryKamera.ArtifactScraper.ScanArtifacts(Int32 count) in C:\play\Inventory_Kamera\InventoryKamera\scraping\ArtifactScraper.cs:line 28
   at InventoryKamera.InventoryKamera.GatherData() in C:\play\Inventory_Kamera\InventoryKamera\data\InventoryKamera.cs:line 148
jofori89 commented 1 year ago

I also got this bug. at InventoryKamera.InventoryScraper.GetPageOfItems(Int32 pageNum, Boolean acceptLess) in C:\play\Inventory_Kamera\InventoryKamera\scraping\InventoryScraper.cs:line 467 After debug the source code, i found out a condition, it is set as 40 items per page, (8 columns and 5 rows). But my invetory only have 35 per page (7 columns x 5 rows), that made the app could not process.

image

Cupcak3 commented 9 months ago

I am closing this issue in favor of #487