Invalid weapon name for event claymore - Githubissues

Andrewthe13th / Inventory_Kamera

Scans Genshin Impact characters, artifacts, and weapons from the game window into a JSON file.

MIT License

694 stars 116 forks source link

Invalid weapon name for event claymore #497

Closed Warimano closed 9 months ago

Warimano commented 10 months ago

Current Behavior

The scanner is unable to read the name of the "Ultimate Overlord's Mega Magic Sword" and just displays "Invalid weapon name" in the error log. Presumably it's due to the quotation marks in the name since there's both double quotes and a single quote(apostrophe).

Expected Behavior

The scanner continues to scan

Reproducing a Behavior

Scan an inventory containing previously mentioned event Claymore

Device OS

Windows 11

Genshin Impact Version

4.3

Inventory Kamera Version

1.3.12

Screen resolution, screen mode, and UI scale

1920x1080

Additional notes and remarks

No response

Evidence

Error at line #42

`2024-01-21 10:01:49.246|INFO|InventoryKamera|Kamera initialized 2024-01-21 10:01:49.449|INFO|MainForm|Inventory Kamera version 1.3.12 2024-01-21 10:01:49.747|INFO|DatabaseManager|Checking for newer game data... 2024-01-21 10:01:50.490|INFO|MainForm|Current game data is up to date with data for 4.3 2024-01-21 10:02:30.106|INFO|MainForm|Starting scan 2024-01-21 10:02:30.106|INFO|MainForm|Hotkey registered 2024-01-21 10:02:30.106|INFO|MainForm|Scan settings: Game Version Data: 4.3 Weapons: True Artifacts: True Characters: True Dev Items: False Materials: False Min Weapon Rarity: 3 Min Weapon Level: 1 Equip Weapons: True Min Artifact Rarity: 4 Min Artifact Level: 0 Equip Artifacts: True Delay: 0 2024-01-21 10:02:30.130|DEBUG|Navigation|Checking for GenshinImpact.exe 2024-01-21 10:02:30.209|DEBUG|Navigation|Found GenshinImpact.exe 2024-01-21 10:02:30.209|DEBUG|Navigation|Window location (2560x1440): x=0, y=0 2024-01-21 10:02:30.324|INFO|InventoryKamera|Kamera initialized 2024-01-21 10:02:30.324|INFO|MainForm|Resolution: 2560x1440 2024-01-21 10:02:30.337|INFO|InventoryKamera|Logging directory reset 2024-01-21 10:02:31.055|INFO|GenshinProcesor|Scraper initialized 2024-01-21 10:02:31.079|DEBUG|InventoryKamera|Added 3 workers 2024-01-21 10:02:31.085|DEBUG|InventoryKamera|Thread #11 priority: Normal 2024-01-21 10:02:31.085|DEBUG|InventoryKamera|Thread #8 priority: Normal 2024-01-21 10:02:31.085|DEBUG|InventoryKamera|Thread #7 priority: Normal 2024-01-21 10:02:31.570|DEBUG|GenshinProcesor|8 Engines restarted 2024-01-21 10:02:31.570|INFO|GenshinProcesor|Internally set traveler custom name to warimano 2024-01-21 10:02:31.570|INFO|GenshinProcesor|Internally set wanderer custom name to kiyoku 2024-01-21 10:02:31.570|INFO|InventoryKamera|Scanning weapons... 2024-01-21 10:02:37.881|INFO|UserInterface|Parsed 322 weapons to scan 2024-01-21 10:02:37.881|INFO|WeaponScraper|Found 322 for weapon count. 2024-01-21 10:02:37.881|DEBUG|WeaponScraper|Sorting by quality to optimize scan time. 2024-01-21 10:02:37.909|DEBUG|WeaponScraper|Inventory is sorted by quality 2024-01-21 10:02:37.909|DEBUG|WeaponScraper|Scanning weapon page 0 2024-01-21 10:02:37.909|DEBUG|WeaponScraper|Located 40 possible item locations on page. 2024-01-21 10:02:44.463|ERROR|UserInterface|Unable to validate information for weapon ID#31 2024-01-21 10:02:44.463|ERROR|UserInterface|Invalid weapon name Weapon ID: 31 Name: Rarity: 4 Level 90 Refinement: 5 Locked: False

2024-01-21 10:02:45.822|DEBUG|WeaponScraper|Finished queuing page of weapons. Scrolling... 2024-01-21 10:02:49.322|DEBUG|WeaponScraper|Scanning weapon page 1 2024-01-21 10:02:49.322|DEBUG|WeaponScraper|Located 40 possible item locations on page. 2024-01-21 10:02:57.250|DEBUG|WeaponScraper|Finished queuing page of weapons. Scrolling... 2024-01-21 10:03:00.754|DEBUG|WeaponScraper|Scanning weapon page 2 2024-01-21 10:03:00.755|DEBUG|WeaponScraper|Located 40 possible item locations on page. 2024-01-21 10:03:08.521|DEBUG|WeaponScraper|Finished queuing page of weapons. Scrolling... 2024-01-21 10:03:12.072|DEBUG|WeaponScraper|Scanning weapon page 3 2024-01-21 10:03:12.072|DEBUG|WeaponScraper|Located 40 possible item locations on page. 2024-01-21 10:03:19.799|DEBUG|WeaponScraper|Finished queuing page of weapons. Scrolling... 2024-01-21 10:03:23.374|DEBUG|WeaponScraper|Scanning weapon page 4 2024-01-21 10:03:23.374|DEBUG|WeaponScraper|Located 40 possible item locations on page. 2024-01-21 10:03:31.191|DEBUG|WeaponScraper|Finished queuing page of weapons. Scrolling... 2024-01-21 10:03:34.728|DEBUG|WeaponScraper|Scanning weapon page 5 2024-01-21 10:03:34.728|DEBUG|WeaponScraper|Located 40 possible item locations on page. 2024-01-21 10:03:42.435|DEBUG|WeaponScraper|Finished queuing page of weapons. Scrolling... 2024-01-21 10:03:45.877|DEBUG|WeaponScraper|Scanning weapon page 6 2024-01-21 10:03:45.877|DEBUG|WeaponScraper|Located 40 possible item locations on page. 2024-01-21 10:03:53.727|DEBUG|WeaponScraper|Finished queuing page of weapons. Scrolling... 2024-01-21 10:03:57.265|DEBUG|WeaponScraper|Scanning weapon page 7 2024-01-21 10:03:57.265|DEBUG|WeaponScraper|Located 40 possible item locations on page. 2024-01-21 10:04:03.103|INFO|WeaponScraper|Stopping weapon scan based on filtering 2024-01-21 10:04:05.118|INFO|InventoryKamera|Done scanning weapons ... `

Preflight Checklist

[X] I have checked for similar issues in the issue page, and I have not found any similar to mine.
[X] I am using the latest version of the scanner.
[ ] I tried setting the scanning delay to maximum, and it still doesn't work.
[ ] I have attached the video recording to the bug report.
[X] I have attached the error log to the bug report.
[X] I am available to later explains the issue.
[X] I have disabled all screen filtering software or plugins (i.e. HDR, Image Sharpening) while scanning.
[X] I use default in-game keybindings or have configured keybindings for the scanner.

Cupcak3 commented 9 months ago

This should be fixed in the latest version