Andrewthe13th / Inventory_Kamera

Scans Genshin Impact characters, artifacts, and weapons from the game window into a JSON file.
MIT License
699 stars 122 forks source link

Artifacts with +sub-stat <10 are not properly scanned #501

Closed dudensen1 closed 9 months ago

dudensen1 commented 10 months ago

EDIT: Not just ATK, +DEF<10 also won't log, maybe Elemental Mastery as well, although I'd have to check 2star artifacts for that one.

Current Behavior

Artifacts with sub-stat ATK+ <10 are not properly scanned. Specifically the artifacts seem to be scanned but the sub-stat does not log. I have no idea if it's just this sub-stat or the 3star artifacts or anything of that sort. I can't pin it down, especially since I'm quite new to the game. The reason I'm saying <10 is because I found a similar (closed) issue that was reported about a year ago.

Expected Behavior

The scanner to correctly exports the data

Reproducing a Behavior

I'm pretty sure it's the <10 ATK thing, which is also what the other person found in the past.

Device OS

Windows 10

Genshin Impact Version

4.3, 4.4

Inventory Kamera Version

1.3.12

Screen resolution, screen mode, and UI scale

1920x1080 fullscreen, 1600x900 windowed

Additional notes and remarks

No response

Evidence

Untitled

Preflight Checklist

dudensen1 commented 10 months ago

Just downloaded the version 13.3.3 on Genshin Impact 4.4 and the problem seems to have been fixed. However, I'm now also having the issue with the rounded decimals (there is already an open issue about this).

Cupcak3 commented 9 months ago

This is fixed in the latest release