Andrewthe13th / Inventory_Kamera

Scans Genshin Impact characters, artifacts, and weapons from the game window into a JSON file.
MIT License
671 stars 112 forks source link

Unable to locate Weapons item count. #507

Open farsdewibs0n opened 6 months ago

farsdewibs0n commented 6 months ago

Current Behavior

Unable to scan weapon count because the OCR doesnt really wait for the Inventory UI to open.

Expected Behavior

The scanner stops scanning

Reproducing a Behavior

-Set Inventory Kamera scan for Weapons -Wait for a bit -Weapon tab was skipped due to "Unable to locate Weapons item count."

Device OS

Windows 10

Genshin Impact Version

4.4

Inventory Kamera Version

1.3.14

Screen resolution, screen mode, and UI scale

1920x1080p borderless

Additional notes and remarks

This probably caused by putting the game on Hard Drive.

Evidence

InventoryKamera.log image

Preflight Checklist

Sw1ftSN commented 6 months ago

I found a temporary fix. Enter your weapons menu (or any other menu) before running the scanner, and things should run as intended.

Seems to me like the delay specifically on the ESC menu is too long.

balthanon commented 4 months ago

I found a temporary fix. Enter your weapons menu (or any other menu) before running the scanner, and things should run as intended.

I've been having issues with weapons not counting correctly and this causing issues with a run and this fixed it for me on an independent run of just weapons, thanks. I'll probably try the same thing on a full run of characters, artifacts, and weapons next time I do that to see if it works there too.

balthanon commented 3 months ago

So tried the workaround today after downloading the new version from github (1.3.16) and it failed for a full run; then also failed on a weapon only run. Not sure what if anything changed, but it does still appear to be an issue. For now, I think I might just manually update my weapon JSON file manually. Those very seldom actually actually change.