Talent level UI updated in 4.5, scanning it is broken

odano27 commented 8 months ago

Current Behavior

Hoyo added this, which changes the talent leveling UI. It's now like this Comparison with earlier versions (which were also in 1920x1080)

The UI change broke the character talent scanning feature for obvious reasons, and now it doesn't work most of the time. I didn't expect it to work at all, but apparently, only a small top bit of the level is cropped off. In the image below, NA level 4 scanned successfully, but E level 8 wasn't, probably due to being cropped.

The scaling doesn't change when you reach level 10/13 so it should be a quick fix.

Expected Behavior

The scanner continues to scan

Reproducing a Behavior

Just run the character scan

Device OS

Windows 11

Genshin Impact Version

4.5

Inventory Kamera Version

1.3.14

Screen resolution, screen mode, and UI scale

windowed 16:9 1080p

Additional notes and remarks

Don't think a log would be necessary

Evidence

No response

Preflight Checklist

[X] I have checked for similar issues in the issue page, and I have not found any similar to mine.
[X] I am using the latest version of the scanner.
[X] I tried setting the scanning delay to maximum, and it still doesn't work.
[X] I have attached the video recording to the bug report.
[X] I have attached the error log to the bug report.
[X] I am available to later explains the issue.
[X] I have disabled (or documented) all screen filtering software, plugins, and enhancements while scanning.
[X] I use default in-game keybindings or have configured keybindings for the scanner.

MRDGH2821 commented 8 months ago

Can you try out my fix? https://github.com/MRDGH2821/Inventory_Kamera/releases/tag/v1.3.15

btcs-nambn commented 8 months ago

@MRDGH2821 windows and chrome detect trojan in your build, what are you trying to do?

MRDGH2821 commented 8 months ago

That is super strange, I changed 4 lines: https://github.com/Andrewthe13th/Inventory_Kamera/compare/v1.3.14...MRDGH2821:Inventory_Kamera:v1.3.15

(Template bug report change is done by project owner, my changes are in AsssemblyInfo.cs & CharacterScrapper.cs)

The source code is public, so you can go ahead and install Visual Studio 2022, compile & run the project from your end

aegasisx commented 8 months ago

@MRDGH2821 i checked the PR and it seems OK but here is the log of window defender

Trojan:Win32/Wacatac.B!ml
Alert level: Severe
Date: 3/14/2024 12:53 AM
Category: Trojan
Details: This program is dangerous and executes commands from an attacker.

containerfile: C:\Users\pegas\Downloads\InventoryKamera-v1.3.15.zip
file: C:\Users\pegas\Downloads\InventoryKamera-v1.3.15.zip->Release/InventoryKamera.exe
webfile: C:\Users\pegas\Downloads\InventoryKamera-v1.3.15.zip|https://objects.githubusercontent.com/github-production-release-asset-2e65be/771530875/23c31b08-9ba2-47f2-b5c6-4cdb7b2de24a?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAVCODYLSA53PQK4ZA%2F20240313%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20240313T175324Z&X-Amz-Expires=300&X-Amz-Signature=95ae8906f70a6825cff13f19681ac39e3fc8f29bd21ede52a2867983ab79acc5&X-Amz-SignedHeaders=host&actor_id=31458952&key_id=0&repo_id=771530875&response-content-disposition=attachment%3B%20filename%3DInventoryKamera-v1.3.15.zip&response-content-type=application%2Foctet-stream|pid:14912,ProcessStart:133548260250054600

I have no problem with downloading or installing Andrewthe13th's version Maybe it is a false positive?

MRDGH2821 commented 8 months ago

Earlier I used NanaZip to compress the folder. Now I used Windows File Explorer to compress it.

And in both cases Microsoft defender didn't catch anything 🤔

InventoryKamera-compressed-via-file-explorer.zip

I'll include build instructions in my repository, so that you guys can build it at your own end & test it.

aegasisx commented 8 months ago

@MRDGH2821 Seem like it is just a false positive 🤔 I will wait for the fix to be merged into main branch for using

Thanks for providing the fix 👍

Jegadish003 commented 7 months ago

InventoryKamera.debug.log

Heyy, just tried the updated version 1.3.15 but it still doesn't seem to work, any other details I can provide ? I am running in Fullscreen 1920 x 1200

MRDGH2821 commented 7 months ago

@Jegadish003 try with 16:9 resolution ratio, for e.g. 1920 x 1080

Jegadish003 commented 7 months ago

It works for 16:9 but not for 16:10

Jegadish003 commented 7 months ago

Will the problem be fixed later or will I have to change the game to 1080 every time ?

Andrewthe13th / Inventory_Kamera