Andrewthe13th / Inventory_Kamera

Scans Genshin Impact characters, artifacts, and weapons from the game window into a JSON file.
MIT License
694 stars 115 forks source link

Scanner fails to locate Artifact Count under specific display conditions #534

Open abarax-rr opened 3 weeks ago

abarax-rr commented 3 weeks ago

Current Behavior

Under specific resolution/scaling conditions, scanner fails to correctly locate Artifact Count and fails scan. Windows 10 changed my display settings without me knowing. I usually use 2560x1440 125% fullscreen for playing, and 1080p 125% windowed for scanning, which worked until today.

I noticed that my Genshin title bar was abnormally small/thin (see video) and after playing around with my display settings, found the culprit - the "Let Windows try to fix apps so they're not blurry", see reproducing behaviour.

Video: https://drive.google.com/file/d/1VFxxa1NqunjP7kTUrOKPQy5QhHkWkWA_/view?usp=sharing

Expected Behavior

The scanner to supports my device configurations (please specify in additional notes)

Reproducing a Behavior

On Windows 10, with 2560x1440 display with 125% display scaling - disable "Settings -> Display -> Scale and Layout -> Advanced Scaling Settings -> Let Windows try to fix apps so they're not blurry" disabled. This causes the Genshin title bar to become extremely thin and the scanner to not recognise the artifact count (see log, it seems to think the resolution is different and so looks in the wrong position).

Enabling the setting made the scanner work again.

Device OS

Windows 10

Genshin Impact Version

5.0

Inventory Kamera Version

1.3.16 (updated to 5.1)

Screen resolution, screen mode, and UI scale

2560x1440, UI scale 125%, "Let Windows try to fix apps so they're not blurry" disabled.

Additional notes and remarks

Screen filtering etc. software: None that I am aware of (OS blue light filter on low settings.

Evidence

InventoryKamera.debug.log genshinData_GOOD_2024_10_09_07_33.json

Preflight Checklist

aaelyxa commented 1 week ago

Also having the same problem. is there any fix for this?

abarax-rr commented 1 week ago

I noted a (temporary) fix in the outline: Toggling "Settings -> Display -> Scale and Layout -> Advanced Scaling Settings -> Let Windows try to fix apps so they're not blurry" should fix it (setting must be enabled for scanner to work).

aaelyxa commented 1 week ago

Yea but I’m on windows 11 and that’s not an option plus my settings are on default (haven’t touched scaling)

On Sun, Oct 20, 2024 at 3:33 AM abarax-rr @.***> wrote:

I noted a (temporary) fix in the outline: Toggling "Settings -> Display -> Scale and Layout -> Advanced Scaling Settings -> Let Windows try to fix apps so they're not blurry" should fix it (setting must be enabled for scanner to work).

— Reply to this email directly, view it on GitHub https://github.com/Andrewthe13th/Inventory_Kamera/issues/534#issuecomment-2424698199, or unsubscribe https://github.com/notifications/unsubscribe-auth/BFX6ZEA63H6JXKZTTBJZPK3Z4NMELAVCNFSM6AAAAABPTDUN7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRUGY4TQMJZHE . You are receiving this because you commented.Message ID: @.***>

abarax-rr commented 1 week ago

Then you don't have the same issue. I outlined the specific conditions/OS, you have different conditions/OS.

aaelyxa commented 1 week ago

its the same issue just different OS wdym.